tuxi icon indicating copy to clipboard operation
tuxi copied to clipboard

Add function to show public holiday result

Open KevCui opened this issue 4 years ago • 16 comments

KevCui avatar Feb 28 '21 21:02 KevCui

Nice. Can you write some test cases for it and send the testoutputs.txt? Or if you don't want to, I can make a new PR with the testcases.

sudocanttype avatar Mar 01 '21 01:03 sudocanttype

K I made a pr to your main for testing. @KevCui

sudocanttype avatar Mar 01 '21 03:03 sudocanttype

Thanks @sudocanttype 👍

KevCui avatar Mar 01 '21 07:03 KevCui

output.txt Proof that it works. If someone else wants to test before we merge in, go for it

sudocanttype avatar Mar 01 '21 15:03 sudocanttype

@BeyondMagic Can you test this branch and see if it works for you? If it does, i think this is ready to merge

sudocanttype avatar Mar 03 '21 15:03 sudocanttype

I think Basic Answers has conflict with Public Holidays, Public Holidays should be put before it.

BeyondMagic avatar Mar 03 '21 17:03 BeyondMagic

Can you give me an example of where it conflicts? I need something to test to fix the problem

sudocanttype avatar Mar 03 '21 18:03 sudocanttype

try "christmas" with both features

BeyondMagic avatar Mar 03 '21 18:03 BeyondMagic

oh yea, i see it

sudocanttype avatar Mar 03 '21 18:03 sudocanttype

also, I think we can add a better sed there, like

holiday's name
* holiday's day
holiday's name
* holiday's day
...

or

holiday's name - holiday's day
holiday's name - holiday's day
holiday's name - holiday's day
...

BeyondMagic avatar Mar 03 '21 18:03 BeyondMagic

what exactly is ./tuxi christmas supposed to return? are we trying to give the definition?

sudocanttype avatar Mar 03 '21 18:03 sudocanttype

I mean, it should, but it's not.

BeyondMagic avatar Mar 03 '21 18:03 BeyondMagic

This doesnt seem to be a problem with the public holiday function. Try checking out the main branch of tuxi and trying ./tuxi christmas. For me it still returns the same thing, so something else is messing with it

sudocanttype avatar Mar 03 '21 18:03 sudocanttype

Oh yeah, I remember fixing this in develop branch, I thought this would fix this too in the main since the name is for public holidays

BeyondMagic avatar Mar 03 '21 18:03 BeyondMagic

How did you fix it in the develop branch?

sudocanttype avatar Mar 03 '21 19:03 sudocanttype

by adding -a to see all results, lol

BeyondMagic avatar Mar 03 '21 19:03 BeyondMagic