tuxi
tuxi copied to clipboard
Add function to show public holiday result
Nice. Can you write some test cases for it and send the testoutputs.txt? Or if you don't want to, I can make a new PR with the testcases.
K I made a pr to your main for testing. @KevCui
Thanks @sudocanttype 👍
output.txt Proof that it works. If someone else wants to test before we merge in, go for it
@BeyondMagic Can you test this branch and see if it works for you? If it does, i think this is ready to merge
I think Basic Answers has conflict with Public Holidays, Public Holidays should be put before it.
Can you give me an example of where it conflicts? I need something to test to fix the problem
try "christmas" with both features
oh yea, i see it
also, I think we can add a better sed there, like
holiday's name
* holiday's day
holiday's name
* holiday's day
...
or
holiday's name - holiday's day
holiday's name - holiday's day
holiday's name - holiday's day
...
what exactly is ./tuxi christmas supposed to return? are we trying to give the definition?
I mean, it should, but it's not.
This doesnt seem to be a problem with the public holiday function. Try checking out the main branch of tuxi and trying ./tuxi christmas. For me it still returns the same thing, so something else is messing with it
Oh yeah, I remember fixing this in develop branch, I thought this would fix this too in the main since the name is for public holidays
How did you fix it in the develop branch?
by adding -a to see all results, lol