jekyll-deploy-gh-pages icon indicating copy to clipboard operation
jekyll-deploy-gh-pages copied to clipboard

Potential issue in README example

Open ibnesayeed opened this issue 5 years ago • 2 comments
trafficstars

Are these GITHUB_REPOSITORY and GITHUB_ACTOR configurations intentional in the README Example? These values are available as environment variables in all runner environments, so why would we namespace them under secrets other than the GITHUB_TOKEN that is created by the user?

        env: 
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
          GITHUB_REPOSITORY: ${{ secrets.GITHUB_REPOSITORY }}
          GITHUB_ACTOR: ${{ secrets.GITHUB_ACTOR }}

ibnesayeed avatar Feb 08 '20 17:02 ibnesayeed

github.repository and github.actor seemed to work for me.

evanw555 avatar Feb 27 '20 22:02 evanw555

I'll have to look at the documentation again—at some point, I think it did have to be explicitly set but maybe that's no longer true.

BryanSchuetz avatar Feb 28 '20 19:02 BryanSchuetz