SQL-Server-First-Responder-Kit
SQL-Server-First-Responder-Kit copied to clipboard
sp_BlitzQueryStore Style Edits
I decided to clean up anything that bothered me in sp_BlitzQueryStore before beginning any serious work on it. These are largely style changes. Summary:
- Minor edits to some comments, mostly typo corrections and edits for consistency with surrounding comments.
- Removed some extra spaces, e.g. double spaces in printed text.
- Moved repeated calls to
SERVERPROPERTYin to variables. Some of these originally wereNVARCHARand others wereVARCHAR. I am not sure if there is a good reason behind this, so I have gone with my the docs.ENGINEEDITIONis an exception to this and has been stored as anINT. - Ruthlessly made the commenting syntax consistent. The most common form in the original was
/*Foo*/so I've applied that everywhere other than the multi-line block comments. Previously, it has--Foo,-- Foo,/*foo*/,/* Foo */, and
/*
I am a single sentence on a single line. This comment block has no other lines of text.
*/
- Added comments for some temp tables that had none.
- Documented the undocumented
@Versionparameters in the@Helptext. - Switched
SELECT TOP NtoSELECT TOP (N)for consistency with other uses ofTOP.
I expect that only point 3 has even the slightest chance of breaking anything. Those variables are mostly used for Azure checks, but I don't have an Azure box to test them on.