grids
grids copied to clipboard
BorisTheBrave
Cleaned up the code a bit
The code did not comply with PEP8 in many places, that was cleaned up.
Using global variable for edge length is very dangerous, especially if user wants to change edge length through the program.
While I appreciate the sentiment, many of these deviations from python standards were deliberate. I am not aiming to write the best python code, but rather the clearest code for learning from, even if you don't understand python. Hence why I have not used features like optional arguments, relative imports, and defined my own mod function (as Python mod does not work like other languages). I've used extra whitespace to make clear the matrix structure of some of the math operations.
Can you please declare that you release your changes into the public domain, and I will look at incorporating some of them into the code base.
@alexpyattaev , I cannot use any of this without a release declaration as it's not under a copyleft license. Please just state that your changes are included under the CC0 license.
Hi Boris, of course it is public domain, no issue with that. Should I add some mark on Github as well? PS: apologies for delays, vacations and whatnot:) BR, Alex.
On July 31, 2021 12:09:52 PM GMT+03:00, BorisTheBrave @.> wrote: @. , I cannot use any of this without a release declaration as it's not under a copyleft license. Please just state that your changes are included under the CC0 license.
-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/BorisTheBrave/grids/pull/1#issuecomment-890316539