BookStack
BookStack copied to clipboard
Add popularity sorting options for books
Now the user can sort the /books by the view_count. It is the #1712 feature request.
Unit tests are added too.
@CodiumAI-Agent /review
PR Reviewer Guide 🔍
(Review updated until commit https://github.com/BookStackApp/BookStack/commit/5d17e991b64a615b281395bcc165e01d23b339c7)
| ⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪ |
| 🧪 PR contains tests |
| 🔒 No security concerns identified |
| ⚡ Key issues to review Possible Bug Code Clarity |
Thanks for offering this @fuszti and sorry for the late response. Personally I'm not too convinced of the value of adding this feature, since there's been little desire for this so far and we already list a few of the most popular books in this view. Plus if we add this here it would also be expected in the shelves view, adding a little complexity there too.
Persistent review updated to latest commit https://github.com/BookStackApp/BookStack/commit/5d17e991b64a615b281395bcc165e01d23b339c7
I'm going to go ahead and close this off as per my comment above.
Oh wow, I somehow missed your previous comment. Thank you for responding to my PR. I understand your point, no worries.