BookStack icon indicating copy to clipboard operation
BookStack copied to clipboard

Inline commenting

Open abbeyjackson opened this issue 6 years ago • 25 comments

This is a suggestion added to issues as per Dan’s instructions via Twitter.

Inline commenting (selecting a chubk of text to comment on or having a comment associated with a specific line number) is a feature that is missing from Bookstack which I feel would really add value to the product.

abbeyjackson avatar Feb 07 '19 15:02 abbeyjackson

Looking forward to get this feature! Bookshelf is perfect replacement for any products which use as WIKI. Inline commentaries would greatly expands work possibilities.

JohnnyWild89 avatar May 18 '20 20:05 JohnnyWild89

This would be a really great feature that would improve the possibility of people collaborating on the documents. Is it possible this feature will make it into the roadmap?

cze-karel avatar Jan 06 '21 07:01 cze-karel

Further request and ideas proposed within #3063

ssddanbrown avatar Nov 19 '21 11:11 ssddanbrown

Any plans on adding annotations (Inline comments) to BookStack? This would be a great addition.

I tried hypothes.is for adding annotations to BookStack pages, but the BookStack text select pop-up interferes with hypothes.

TiemeWoldman avatar Jul 07 '22 07:07 TiemeWoldman

As far as I can tell BookStack is pretty close to perfect for a writing / collaboration platform. Super simple to use, very intuitive. Inline comments would make it perfect! Is this something you are working on or have an ETA for? Thanks

EDMJohnny avatar Aug 15 '22 13:08 EDMJohnny

@EDMJohnny

Is this something you are working on or have an ETA for?

Not at this time.

ssddanbrown avatar Aug 15 '22 15:08 ssddanbrown

Thanks for responding. Is this something you'd be willing to put a bounty on / get paid for completing? Do you have a ballpark for cost of adding this feature?

EDMJohnny avatar Aug 15 '22 18:08 EDMJohnny

@EDMJohnny I'm not really a fan of public bounties, can just cause issues. Not really sure on ballpark costs either as this would need fleshing out into a full proposal since this request could be imagined/desired in different forms.

I've quoted features before (although never accepted) but only for features with clear scope and platform fit. Something makes me uneasy about rushing through a proposal for the sake of money, feel that risks providing an unbalanced larger voice to those with money, not sure the right way to balance that. If I was to quote it'd be somewhere upwards of £1k, even for a minimal implementation.

ssddanbrown avatar Aug 15 '22 21:08 ssddanbrown

Why not integrate something like https://github.com/recogito/recogito-js ? It looks like a significant portion of the functionality is already implemented.

danhansen avatar Aug 26 '22 19:08 danhansen

@ssddanbrown can we please have this added to a roadmap in some regard? As you may remember seeing me elsewhere, likely to switch to Bookstack, and some of our staff use this kind of feature in Confuence (which we are moving away from).

Is there a hurdle on your end for this?

BloodyIron avatar Sep 29 '22 22:09 BloodyIron

Is there a hurdle on your end for this?

Uh, I guess it's some level of formula of:

PRESSURE = ("user actual benefit" + "user demand" + "my own enthusiasm level for the feature")
DRAG = ("implementation cost" + "my predicated cost of maintenance, inc. support")
HURDLE = ((PRESSURE - DRAG) * "my current emotions" * RANDOM_CHANCE())

That's probably the best I can explain it, same for any feature tbh. Roadmap is reserved for high-level elements. Could maybe have some kind of "Commenting and Communications" item. Not sure though, might want to address other things before.

Realistically, the next step for this specific request would be for me to put forward an implementation proposal, with a scope that I'd be happy to maintain, for community feedback. No reason to rush though IMO.

ssddanbrown avatar Sep 30 '22 00:09 ssddanbrown

Agreed with EDMJohnny above that inline comments to facilitate more specific conversation amongst collaborators is one of the biggest items of value that could be added.

Also inline with EDMJohnny about the bounty, would be happy to chip in

ironbelly avatar Nov 07 '22 20:11 ironbelly

@ssddanbrown Hi - just checking in again. I see you've done a lot of updates on Bookstack since I last checked it. All much appreciated. Any chance of bumping this feature request for inline comments on to your To Do?

EDMJohnny avatar Mar 02 '23 02:03 EDMJohnny

This would be a killer feature !

ipimpat avatar Mar 26 '23 23:03 ipimpat

This feature would be great! :)

rosequaartz avatar Apr 27 '23 19:04 rosequaartz

Yeah, with this feature, bookstack can knock the ball out of the park !

shashankvivek avatar May 07 '23 17:05 shashankvivek

I stumbled on this issue and wanted to chip in. We use bookstack for our open source community. People are working together on projects and keep reverting to google docs. Inline comments are the missing key in bookstack and holding them back to make the switch. I hope this will add some weight to the "user actual benefit" + "user demand" parts of the equation. Either way, thanks for this nice piece of software!

stevenvegt avatar Feb 01 '24 07:02 stevenvegt