Tree icon indicating copy to clipboard operation
Tree copied to clipboard

Why do you need to change letter case, how now to output fields by their original names?

Open scion4581 opened this issue 1 year ago • 3 comments

https://github.com/BlueM/Tree/blob/ded69515db52cb95afd9655d632bfffc6494641c/src/Tree/Node.php#L40C9-L40C76

scion4581 avatar Aug 02 '24 10:08 scion4581

This was a deliberate decision (quite some time ago) with the goal to make access via getters case-insensitive with minimal performance overhead. (See #32) Nowadays, I’d wouldn’t implement it like that anymore, and it’s very likely that this will change in the next major version.

BlueM avatar Aug 02 '24 18:08 BlueM

@BlueM Are you teasing us with a "next major version" hint in there? Is there active development happening?

Will you accept pull requests from the community to help move this project forward? Then we could help address suggestions like mentioned here.

TheDigitalOrchard avatar Aug 13 '24 19:08 TheDigitalOrchard

@TheDigitalOrchard: there hadn’t been active development for a long time, but as it became increasingly obvious the code could need some modernizations, I’ve started working on some improvements recently. Among other things, in my local Git repo, the properties are no longer normalized to lowercase.

It’s very likely I will push the changes to a v4 branch, so anyone who is interested can experiment with it before a v4 is tagged, and potentially submit PRs.

BlueM avatar Aug 25 '24 12:08 BlueM

As of now, master contains a bunch of changes, including not normalizing properties to lowercase. See changelog in README for more information.

BlueM avatar Jun 23 '25 18:06 BlueM