saythanks.io icon indicating copy to clipboard operation
saythanks.io copied to clipboard

Improve pull_request_template.md file

Open kgashok opened this issue 3 years ago • 2 comments

Review https://github.com/appium/appium/blob/master/.github/PULL_REQUEST_TEMPLATE.md

Discuss which parts are relevant to this project, and add/modify the current template, including moving it to /docs directory.

@Pavithratrdev

kgashok avatar Jan 07 '22 16:01 kgashok

Sure sir, will do it

Pavithratrdev avatar Jan 08 '22 22:01 Pavithratrdev

Some other formats:

What does this PR do?

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • [ ] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • [ ] Did you read the contributor guideline, Pull Request section?
  • [ ] Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [ ] Did you make sure to update the documentation with your changes? (if necessary)
  • [ ] Did you write any new necessary tests? (not for typos and docs)
  • [ ] Did you verify new and existing tests pass locally with your changes?
  • [ ] Did you list all the breaking changes introduced by this pull request?
  • [ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR. Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • [ ] Is this pull request ready for review? (if not, please submit in draft mode)
  • [ ] Check that all items from Before submitting are resolved
  • [ ] Make sure the title is self-explanatory and the description concisely explains the PR
  • [ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

kgashok avatar Jan 09 '22 04:01 kgashok