Canvas icon indicating copy to clipboard operation
Canvas copied to clipboard

Added OnClick and OnMouse actions for Canvas

Open KristofferStrube opened this issue 5 years ago • 11 comments

As described in issue #83

KristofferStrube avatar Jun 16 '20 14:06 KristofferStrube

I accidentally continued working with other things on the same branch. That has been reverted now. I'm new to making Pull Requests.

KristofferStrube avatar Jun 22 '20 21:06 KristofferStrube

Did ondblclick was included?

Thaina avatar Feb 07 '21 19:02 Thaina

Hey @ummerland I must have missed a notification at some point, sorry. But I added the handlers you described now. And added the handler that @Thaina requested as well together with the OnContextMenu handler.

KristofferStrube avatar Feb 07 '21 20:02 KristofferStrube

Very nice, thanks @KristofferStrube

ummerland avatar Feb 07 '21 20:02 ummerland

@ummerland Do we have any chance this would be updated in nuget? Or we need to build this ourselves? It seem this repo don't get any updated for a whole year

Thaina avatar Feb 08 '21 01:02 Thaina

Sorry for the late update, we coming to this package and get review the feature PR and also update the package to .NET 5.0, thanks for the contrib.

attilah avatar Feb 15 '21 05:02 attilah

@attilah regarding the conflict with blazor.extensions.canvas.js which is auto-generated. Which version should be used? Doesn't seem like it would actually need to change with the modifications I've made to the project.

KristofferStrube avatar Feb 25 '21 10:02 KristofferStrube

@tbm0115 I had some problems with my merge as you can see, but there are no conflicts now. You can just squash my commits.

KristofferStrube avatar Oct 27 '21 15:10 KristofferStrube

Hi,

I'm wondering if this change made it into the release, or maybe it got lost somewhere?

I get an error System.InvalidOperationException: Object of type 'Blazor.Extensions.Canvas.BECanvas' does not have a property matching the name 'onmousedown'

neilgd avatar Feb 20 '22 20:02 neilgd

Hey @neilgd, No this never got merged into the master branch.

KristofferStrube avatar Feb 21 '22 00:02 KristofferStrube

Hey @neilgd, No this never got merged into the master branch.

Any chance this is going to be merged at some point? Been sitting here for quite a while.

sethfduke avatar Apr 07 '23 17:04 sethfduke