bitcoin-php icon indicating copy to clipboard operation
bitcoin-php copied to clipboard

Update mdanter/ecc to accept v1 and unblock php 8 upgrade

Open BafS opened this issue 4 years ago • 3 comments
trafficstars

mdanter/ecc v0.5 requires php ^7.0, the v1 handle php 8 and there is no breaking change

Diff between v0.5.2 and v1.0.0: https://github.com/phpecc/phpecc/compare/v0.5.2...v1.0.0 Release note: https://github.com/phpecc/phpecc/blob/master/doc/release-notes-1.0.0.md

BafS avatar Apr 21 '21 13:04 BafS

@afk11 would it be possible to merge this PR ? It's our last blocker to upgrade to PHP 8

BafS avatar May 05 '21 16:05 BafS

We had to fork; https://github.com/ProtonMail/bitcoin-php and protonlabs/bitcoin on packagist

BafS avatar Aug 18 '21 15:08 BafS

We had to fork; https://github.com/ProtonMail/bitcoin-php and protonlabs/bitcoin on packagist

Thanks you saved me the pain, Im working on a package that requires https://github.com/kornrunner/php-keccak and it require mdanter/eec v1 and worse my php version was 8.4. Tnanks

envatic avatar Apr 13 '22 12:04 envatic