tidyCDISC icon indicating copy to clipboard operation
tidyCDISC copied to clipboard

ADLB variables not available in nested freq

Open AARON-CLARK opened this issue 3 years ago • 5 comments

Specifically, looking to get freqs of ANRIND for each paramcd.

image

image

AARON-CLARK avatar Feb 25 '22 12:02 AARON-CLARK

@AARON-CLARK is there a reason we aren't included all factor/character fields from ADLB (if included in the datafile)?

Jeff-Thompson12 avatar Sep 13 '22 20:09 Jeff-Thompson12

@AARON-CLARK is there a reason we aren't included all factor/character fields from ADLB (if included in the datafile)?

Not that I know of (or can recall) at the moment.

AARON-CLARK avatar Sep 14 '22 02:09 AARON-CLARK

@AARON-CLARK & @Jeff-Thompson12 :

It looks like the code does not currently allow Nested Frequency for BDS variables. I get an error when I try it: "Can't calculate Distinct Frequency for for BDS variables":

image

The error comes from app_nested_freq.BDS():

https://github.com/Biogen-Inc/tidyCDISC/blob/5bde4910e10d79d83368e82f5da27b1b171f6fbc/R/mod_tableGen_fct_nested_freq.R#L294-L298

Should app_nested_freq.BDS() instead use just app_nested_freq.default()? Is there a reason why BDS datasets should be treated differently for this stat?

tdwils avatar Dec 23 '22 15:12 tdwils

@Jeff-Thompson12, in hindsight, this issue doesn't really make sense. BDS data is full of parameters that are displayed on the left hand side as seen below.

image

So, it doesn't make sense to add "ALB" into the dropzone, because those are quantitative AVALs, not categorical values to use for frequencies.

I think this issue can be closed, unless you have any comments/insight into what I was trying to do last year?

AARON-CLARK avatar Jan 05 '23 20:01 AARON-CLARK

We discussed on 1/6 that we'll investigate with a PR. Aaron just gave a bad example above, but we want to explore including more than just ADSL and ADAE categorical variables in the dropdown, if present.

AARON-CLARK avatar Jan 06 '23 18:01 AARON-CLARK