tidyCDISC icon indicating copy to clipboard operation
tidyCDISC copied to clipboard

Visualizing new version of IDEAFilter

Open AARON-CLARK opened this issue 2 years ago • 2 comments

Corresponding to: https://github.com/Biogen-Inc/IDEAFilter/pull/18/files

With new additions to NEWS file:

  • Fix bug that was trying to assign an attribute to a NULL (#15)
  • Fix bug that was causing inaccurate filtering for datetime vectors (#17)
  • Add new implementation IDEAFilter() that uses a more modern implementation and less resources (#22)
  • Allow user to restrict filter to a subset of columns (#14)
  • Upgraded pillar::new_pillar_type() to pillar::type_sum() (#9)
  • Allow user to easily erase the applied filters
  • Delete inputs and observers from vector modules when exiting them

AARON-CLARK avatar Aug 21 '23 16:08 AARON-CLARK

@AARON-CLARK the answer to all the above is "No". I set this branch up as an easy way to see the new look and performance of the improved IDEAFilter (also helped me find and fix a few bugs). Once we update IDEAFilter on CRAN, I will work more formally to integrate it into tidyCDISC.

Jeff-Thompson12 avatar Aug 21 '23 17:08 Jeff-Thompson12

Codecov Report

Merging #247 (f74280f) into devel (19a0559) will increase coverage by 4.08%. Report is 82 commits behind head on devel. The diff coverage is 71.97%.

:exclamation: Current head f74280f differs from pull request most recent head 8bf38e0. Consider uploading reports for the commit 8bf38e0 to get more accurate results

@@            Coverage Diff             @@
##            devel     #247      +/-   ##
==========================================
+ Coverage   19.26%   23.35%   +4.08%     
==========================================
  Files          54       56       +2     
  Lines        4771     5036     +265     
==========================================
+ Hits          919     1176     +257     
- Misses       3852     3860       +8     
Files Changed Coverage Δ
R/mod_indvExp_srv.R 0.00% <0.00%> (ø)
R/mod_indvExp_ui.R 0.00% <0.00%> (ø)
R/mod_popExp.R 0.00% <0.00%> (ø)
R/mod_popExp_ui.R 0.00% <0.00%> (ø)
R/mod_tableGen.R 0.00% <0.00%> (ø)
R/mod_tableGen_ui.R 0.00% <0.00%> (ø)
R/mod_tableGen_utils.R 0.00% <0.00%> (ø)
R/zzz.R 0.00% <0.00%> (ø)
R/blockData.R 68.92% <68.92%> (ø)
R/mod_tableGen_fct_methods.R 74.28% <92.70%> (+20.23%) :arrow_up:

... and 2 files with indirect coverage changes

codecov[bot] avatar Sep 22 '23 15:09 codecov[bot]