css-star-rating icon indicating copy to clipboard operation
css-star-rating copied to clipboard

Published 20 hours ago • verified publisher icon BioPhoton

Add "bp-" prefix to prevent class collapse #9

Open felipefialho opened this issue 7 years ago • 6 comments
trafficstars

I test it using the styleguide 🍕😄

But the dist folder also has the same files of src, I've don't know if it is a problem.

Can you test it? @BioPhoton

felipefialho avatar Aug 15 '18 16:08 felipefialho

Oh wow nice! Thanks a lot!!! I'll have a detailed look in some days. Under heavy workload. But so far the diff looks good

BioPhoton avatar Aug 18 '18 10:08 BioPhoton

Yes, have a lot of places to test it, hahaha

But, apparently, it works 😹

felipefialho avatar Aug 20 '18 14:08 felipefialho

Have you news about it?

felipefialho avatar Oct 29 '18 16:10 felipefialho

@BioPhoton Can I merge it? 🤔

felipefialho avatar Nov 18 '19 13:11 felipefialho

Hi @felipefialho !

Thanks for the PR (a little late).

@billyjov and I discussed the prefix and we would prefer to go with sr (star-rating) as independent of an account.

Would it be OK for you to change this?

BioPhoton avatar Jan 03 '22 20:01 BioPhoton

Hi @BioPhoton, I agree with this new approach but I don't have time to adjust it anymore :(

If you can, is a good idea use my branch because already have the prefix bp, so you just need to change the names (and add prefix with the new codes since my PR in 2018)

felipefialho avatar Jan 26 '22 13:01 felipefialho