css-star-rating icon indicating copy to clipboard operation
css-star-rating copied to clipboard

Prefix css class names

Open brackio opened this issue 7 years ago • 9 comments
trafficstars

Can you prefix your classes. Some of your css classes have general names (for example: "rating"), and it is causing css conflicts with my app css classes.

Current behavior CSS class are not prefix.

Expected behavior Add prefix to CSS classes to avoid conflicts. For example, instead of class-name "rating", it should be renamed to "asr-rating".

Following classes are effected:

  • .rating
  • .star
  • .star-container
  • .label-value

Todos:

  • [ ] change classnemes in scss files => use the #{$var} syntax
  • [ ] change classnames in KSS docs
  • [ ] change classnames in Readme.md

brackio avatar Feb 08 '18 15:02 brackio

What classes would you suggest?

  • .rating
  • .star
  • .star-container
  • .label-value

Are there some more?

BioPhoton avatar Feb 24 '18 14:02 BioPhoton

@brackio any suggestions? thx

BioPhoton avatar Apr 07 '18 15:04 BioPhoton

We can use BEM to isolate it and improve performance.

The block name can be bp-rating (because @BioPhoton 😂 ).

felipefialho avatar Jun 21 '18 20:06 felipefialho

Cool! Or sr.

@LFeh If you provide a proposal just the list of new class names this would be cool.

I could also add you as a collaborator if you want?

BioPhoton avatar Jul 07 '18 20:07 BioPhoton

Great! I can change directly and send a PR 😄

felipefialho avatar Jul 10 '18 14:07 felipefialho

I am close to a big project delivery on my job. I'll get this task in the next days.

Sorry my delay.

felipefialho avatar Jul 18 '18 14:07 felipefialho

Fine! Thx a lot 😀

BioPhoton avatar Jul 19 '18 11:07 BioPhoton

In the next week I'll can do it 😄

felipefialho avatar Aug 10 '18 15:08 felipefialho

You can test if everything is working by running npm run styleguide and open the generated index.html in the docs folder.

BioPhoton avatar Aug 14 '18 22:08 BioPhoton