css-star-rating
css-star-rating copied to clipboard
Prefix css class names
Can you prefix your classes. Some of your css classes have general names (for example: "rating"), and it is causing css conflicts with my app css classes.
Current behavior CSS class are not prefix.
Expected behavior Add prefix to CSS classes to avoid conflicts. For example, instead of class-name "rating", it should be renamed to "asr-rating".
Following classes are effected:
- .rating
- .star
- .star-container
- .label-value
Todos:
- [ ] change classnemes in scss files => use the
#{$var}syntax - [ ] change classnames in KSS docs
- [ ] change classnames in Readme.md
What classes would you suggest?
- .rating
- .star
- .star-container
- .label-value
Are there some more?
@brackio any suggestions? thx
We can use BEM to isolate it and improve performance.
The block name can be bp-rating (because @BioPhoton 😂 ).
Cool! Or sr.
@LFeh If you provide a proposal just the list of new class names this would be cool.
I could also add you as a collaborator if you want?
Great! I can change directly and send a PR 😄
I am close to a big project delivery on my job. I'll get this task in the next days.
Sorry my delay.
Fine! Thx a lot 😀
In the next week I'll can do it 😄
You can test if everything is working by running npm run styleguide and open the generated index.html in the docs folder.