biopandas
biopandas copied to clipboard
Esmfold
Description
Adds support for retrieving predicted structures from ESMFold.
Pull Request Checklist
- [ ] Added a note about the modification or contribution to the
./docs/sources/CHANGELOG.mdfile (if applicable) - [x] Added appropriate unit test functions in the
./biopandas/*/testsdirectories (if applicable) - [x] Modify documentation in the corresponding Jupyter Notebook under
biopandas/docs/sources/(if applicable) - [x] Ran
PYTHONPATH='.' pytest ./biopandas -svand make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g.,PYTHONPATH='.' pytest ./biopandas/classifier/tests/test_stacking_cv_classifier.py -sv) - [ ] Checked for style issues by running
flake8 ./biopandas
Check out this pull request on ![]()
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
@a-r-j It looks all good to me! Just added source='esmfold-v1' as a requirement if someone fetches a sequence. Just so that people now what they are fetching it from.
I noticed that the PDB jupyter notebook is corrupted though. Couldn't open it on my computer, and I also see that that it's the same for Gh rendering: https://github.com/rasbt/biopandas/blob/4515e39861a422c10a8aff7677ecd5aacb031508/docs/tutorials/Working_with_PDB_Structures_in_DataFrames.ipynb
Do you have a working version on your computer still? Othewise I will restore it from an earlier commit.
Oh gosh, let me see what I can do. Keeping notebooks under version control is always a nightmare.
Seems I hadn't resolved all the conflicts when merging. Should be fixed now :)
Thanks, I will try to check that out today! I will also take care of the docs. But just if you are curious, there are a few notes here: https://biopandas.github.io/biopandas/CONTRIBUTING/#notes-for-the-developers
PS: I transferred the repo to a new BioPandas org. Looks like everything worked pretty smoothly so far
I think you undid my commits where I added source='esmfold-v1' as a requirement including unit tests 😢
Oh gosh, my bad. Looks like I showed up to amateur hour :sweat:
I can't find your changes in the commit history - any chance you have a local copy?
No worries, thinks happen. Unfortunately, I destroyed them when I pulled your recent branch ... arg