biopandas icon indicating copy to clipboard operation
biopandas copied to clipboard

Adding 200m structures to biopandas

Open a-r-j opened this issue 3 years ago • 3 comments
trafficstars

Small update to support AF2 v3.

Very high structure:code ratio in this PR 😁

a-r-j avatar Aug 02 '22 05:08 a-r-j

Hello @a-r-j! Thanks for updating this PR.

Line 83:54: W291 trailing whitespace Line 84:89: E501 line too long (102 > 88 characters) Line 119:17: E128 continuation line under-indented for visual indent Line 119:89: E501 line too long (96 > 88 characters)

Line 148:13: W503 line break before binary operator Line 163:13: W503 line break before binary operator

Line 131:54: W291 trailing whitespace Line 132:89: E501 line too long (109 > 88 characters) Line 168:17: E128 continuation line under-indented for visual indent Line 168:89: E501 line too long (99 > 88 characters)

Line 154:13: W503 line break before binary operator Line 172:13: W503 line break before binary operator

Comment last updated at 2022-08-06 04:25:25 UTC

pep8speaks avatar Aug 02 '22 05:08 pep8speaks

Thanks a lot for the update!

rasbt avatar Aug 04 '22 16:08 rasbt

It looks like tests are failing due to metadata changes in the local AF2 pdb/mmcif files. I'll fix this up.

a-r-j avatar Aug 04 '22 17:08 a-r-j

Thanks! So it looks like they also updated the previous alphafold-v2 structures? If that's just the meta-data, theoretically we could also just check for Atom entries. Otherwise, I am not sure whether we would have to update the check every few months or so 😅

rasbt avatar Aug 05 '22 15:08 rasbt

It looks like it was just metadata. They just changed the date in the PDB file. In the mmCIF there were more changes but coords are unaffected. I added another block to test for the latest release but updated the old test to make sure everything works nicely with retrieving structures from previous releases too.

a-r-j avatar Aug 06 '22 04:08 a-r-j

Awesome, thanks!

rasbt avatar Aug 06 '22 14:08 rasbt