napari-clusters-plotter
napari-clusters-plotter copied to clipboard
BiAPoL
Plugin not compatible with histogram2d data
Many methods won't work in 0.9.0 if the active_artist is set to HISTOGRAM2D, mainly because they only exist for the SCATTER artist.
We should check in biaplotter that both classes have common methods so that transitioning form one artist to another runs smoothly.
Hi @zoccoler , I was dreading to go at this but you're right, of course 🙈
I think a lot of it can be escaped by just adding checks whether the artist is a histogram, and just returning if it was. Maybe for starters we could add some tests to the plotter that does all of the tests for both scatter and histogram2d plot so that we get an overview of where to start?
I think it would be best to match methods as much as possible to make the code smoother.
I started this and this as attempts to solve this. Both are drafts because they are not fully working yet.
The histogram is important since some collaborators use it, so we should have it in 0.9.0 IMO
The histogram is important since some collaborators use it, so we should have it in 0.9.0 IMO
completely agree 👍
@zoccoler histogram support is back with #387 👍 I think for releasing 0.9.0 this issue can be closed, altough there are a bunch of features of the histogram plot which are not wired correctly in the clusters-plotter (i.e., bin size, etc). The bigger part of the functionality (histogram & overlays) works correctly though :)
That's great! Thanks!
I think the specific histogram features are not that many. Of course, we don't need all of them, I would consider connecting at least the histogram colormap, the log scale and the number of bins, which are available in the current version. The overlay colormap for non-categorical features could remain fixed for the time being (maybe jet or viridis, something other than and different from magma, which is the default colormap of the histogram).