add LAYER_SELECTED_DATA_CLUSTER_ID to cluster from layer space

[ClementCaporal]

Hello,

Attempt to close #363

In this PR I propose to add to v.0.9.0 the point layer features column LAYER_SELECTED_DATA_CLUSTER_ID.

The event connection is added during _on_update_layer_selection (and never removed?). This allow the user to select points in the layer to appear on the plotter canvas through features.

---

v0.9.0 seems amazing! For example, the ability to select several layers and to plot them on the same plotter canvas is something I didn't know I needed.

I feel I didn't understand how to change the color_indices by using another CLUSTER_ID than MANUAL_CLUSTER_ID but maybe it is not implemented yet?

I tried to keep the PR minimal because I am unsure about how v0.9.0 will be developed, but I can of course change the implementation / names.

Thank you for your time

[zoccoler]

Hi @ClementCaporal ! Hey, thanks for your interest in the plugin and for already helping out with a PR! 🎉 Our team is at the moment preparing contents for a course and we will resume 0.9.0 efforts early next month. Maybe before, but I can't promise. I hope it is OK for you if we review this by then! Thanks for your patience and enthusiasm!

[ClementCaporal]

Hello @zoccoler ,

Thank you for your message! I hope you take your time and enjoy your course preparation.

[jo-mueller]

Hi all - I am only seeing this now, will look at it soon hopefully! Thanks @ClementCaporal for the PR already!

Edit: removed all tag 😅

[ClementCaporal]

I don't imagine how often @ ALL is tagged. Might be like famous et Al. contributor https://scholar.google.nl/citations?user=qGuYgMsAAAAJ&hl=en

[jo-mueller]

Hi @ClementCaporal , just a quick update for you here: We are working on a more stratified way of handling colors so that cololring points in the plotter by arbitrary features will be easier. To be compliant with the new functionality, it should be enough if you add the selected items from the point cloud as a new feature to the respective layer's feature (as you already do it) - you'll only have to make sure that it's a column of type categorical` so that the plotter handles it correctly.

[ClementCaporal]

Ok I will add the categorical type constrain to the PR and update also the previous feedback. You can also update the branch if I take too long (writing thesis..)

[jo-mueller]

@ClementCaporal seems like I accidentally closed this PR by deleting the target branch 😬 Please don't interpret it as if your contribution isn't wanted!

[ClementCaporal]

Hello @jo-mueller, Thank you for letting me know. No problem, It happened to me once!

I plan to update (reopen) the PR this weekend.