Pgup/pgdown behavior is now cyclical. This is a behavioral change from before

[dkogan]

trafficstars

• Bug Report

GEEQIE VERSION

Geeqie 1.6+git20210130-5e1d3224 GTK3

Latest from git as of today

GTK-3

OS / DISTRIBUTION

Debian/sid

SUMMARY

This is a change from previous behavior. Previously, when we look at multiple files, there would be a concept of beginning and end of the sequence. The user could hold pgdown to go to the end. Now geeqie just cycles back to the beginning, and it's impossible to tell where the "end" is. This is significant. For instance, it's no longer possible to quickly determine how many files are in the set currently displayed.

STEPS TO REPRODUCE

1. geeqie 1.jpg 2.jpg 3.jpg. We're looking at 1.jpg, and geeqie knows that we care about those 3 files only, so pgup/pgdown cycles between those 3 files
2. pgup. We're at the start of the sequence, so geeqie should do nothing (and that's what it would do before). Now it wraps around to 3.jpg

[thecursedfly]

I cannot reproduce this with Geeqie 1.6 (flatpak version). Using pgup and pgdown does not cycle the set of images. But I may be using an earlier (released) version than what is reported here.

[dkogan]

This is a different issue, but stems from the same thing that's causing the issue described here: geeqie is re-sorting the images given on the commandline. So if I say geeqie 3.jpg 1.jpg 2.jpg it'll show them in the 1-2-3 order instead of the specified 3-1-2 order. It shouldn't do that.

[caclark]

This is a different issue.....

I think this is because of the sort order in the files pane. There is no manual sort order for the files pane, so the order is whatever you have set in the combo.

There is a manual sort order for Collections, but this shows up other problems. If the command: geeqie --list a b c is executed, I would expect the Collection window to open with the files in the listed order, with a selected, and the main image window also showing a. Back/forward should then cycle through the order as set in the Collections window. That does not happen.

[caclark]

If the command: geeqie --list a b c is executed, I would expect the Collection window to open with the files in the listed order, with a selected, and the main image window also showing a. Back/forward should then cycle through the order as set in the Collections window.

This is fixed in commit 84d6373e9

[dkogan]

Thanks. That's better. But some things become worse:

• I would need --list, while this kind of behavior should be the default. Otherwise geeqie re-sorts the images and loops the list, and qualitatively behaves differently if you ask for images in different directories. Do with think most people want those behaviors?

• The "collections" window does come up. I use a tiling WM, so that's the last window that comes up, and it comes up on top of the window showing the image. I then need to switch windows after launching geeqie to actually see the images. But I don't want to actually interact with the collections window, so I'd rather it not come up at all. It could be a pane somewhere, or maybe there could be a switch to turn it off?

Thanks

[caclark]

There are two commits which might affect this:

Selected files may now be traversed either in an end-to-end manner or in a circular manner (as previously). The option is in Preferences/Behavior

The order files were selected in ViewIcon mode is now preserved after a Reset. This means the command line selection order is also preserved. (ViewList does not preserve the selection order).

[dkogan]

Excellent! I see this working much better now. Related (and very expected :) ) questions:

• Can the --list become a checkbox in Preferences/Behavior ?
• Can we get another checkbox to not actually show a collections window?
• I see a popup dialog on exit: "Collections have been modied. Exit anyway?". I didn't "modify" anything. I just looked at some images. Can we suppress this dialog?
• Any way to support multiple instances of the same file being viewed? A user may want to look at images 1,2,3,2,1 in that order. Currently each image can appear at most once in the collections list.

Thanks for working on this!