litellm icon indicating copy to clipboard operation
litellm copied to clipboard

Adding native support for Snowflake's Cortex LLM service

Open sfc-gh-alherrera opened this issue 1 year ago • 5 comments

Title

Adding native support for Snowflake's Cortex LLM endpoint (https://docs.snowflake.com/en/user-guide/snowflake-cortex/llm-functions)

Type

🆕 New Feature 📖 Documentation

sfc-gh-alherrera avatar Sep 29 '24 18:09 sfc-gh-alherrera

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 0:13am

vercel[bot] avatar Sep 29 '24 18:09 vercel[bot]

Ack

krrishdholakia avatar Oct 05 '24 13:10 krrishdholakia

Hi @sfc-gh-alherrera can you add tests for sync + async completion + streaming here (start function name with test_- https://github.com/BerriAI/litellm/blob/fac3b2ee4238e614dc1f077475d9943dbafbc3a4/tests/local_testing/test_completion.py#L4

It's okay if the backend is mocked

e.g. here's how we do it for huggingface - https://github.com/BerriAI/litellm/blob/fac3b2ee4238e614dc1f077475d9943dbafbc3a4/tests/local_testing/test_completion.py#L1806

Once you're done, just share a screenshot of it passing your tests and it should be good to merge!

krrishdholakia avatar Oct 05 '24 22:10 krrishdholakia

@krrishdholakia this is ready for review. Here are the test screenshots. Having issues with asynch support, but complete streaming complete are good to go. Screenshot 2024-10-14 at 8 12 28 PM Screenshot 2024-10-14 at 8 12 17 PM

sfc-gh-alherrera avatar Oct 15 '24 00:10 sfc-gh-alherrera

@krrishdholakia do you have an comments on the latest changes? thanks

sfc-gh-alherrera avatar Oct 21 '24 12:10 sfc-gh-alherrera

Hi @krrishdholakia , wondering if this PR looks good ? Would be really helpful if we can get this feature

sumitdas66 avatar Feb 11 '25 16:02 sumitdas66

hey @sumitdas66 thanks for the bump - i'll try and review it this week.

We do want to add snowflake support, so aligned on ensuring a solution is out.

krrishdholakia avatar Feb 11 '25 18:02 krrishdholakia

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Apr 22 '25 22:04 CLAassistant

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Jul 22 '25 00:07 github-actions[bot]