litellm icon indicating copy to clipboard operation
litellm copied to clipboard

Optimize Alpine Dockerfile by removing redundant apk commands

Open PeterDaveHello opened this issue 1 year ago • 2 comments
trafficstars

Title

Optimize Alpine Dockerfile by removing redundant apk commands

Type

🧹 Refactoring

Changes

Remove unnecessary apk update and manual cache cleanup steps in the Alpine Dockerfile. By using apk add --no-cache, we avoid manual cache management, making the Dockerfile simpler and easier to maintain.

[REQUIRED] Testing - Attach a screenshot of any new tests passing locall

If UI changes, send a screenshot/GIF of working UI fixes

I successfully built the Docker image:

REPOSITORY                   TAG                  IMAGE ID       CREATED         SIZE
litellm-dockerfile           apk-cache-optimiza   ca617f454c3e   21 hours ago    1.46GB

PeterDaveHello avatar Aug 02 '24 13:08 PeterDaveHello

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2025 4:28pm

vercel[bot] avatar Aug 02 '24 13:08 vercel[bot]

Hi @ishaan-jaff @krrishdholakia Should we proceed with completing this PR? Thanks.

PeterDaveHello avatar Oct 18 '24 16:10 PeterDaveHello

@ishaan-jaff @krrishdholakia please let me know if you'd like me to resolve the conflict and make you a better Dockerfile ;)

PeterDaveHello avatar Feb 15 '25 16:02 PeterDaveHello

Sure let's do that

krrishdholakia avatar Feb 15 '25 16:02 krrishdholakia

Thanks, @krrishdholakia! It's all done. I would be happy to help improve it further after this one if you'd like. Just let me know if everything looks good to go.

PeterDaveHello avatar Feb 15 '25 16:02 PeterDaveHello

Sure - any improvements are welcome.

For the next pr - if you can attach a screenshot / some proof of it working, that would help accelerate the review on our end!

krrishdholakia avatar Feb 15 '25 16:02 krrishdholakia

Sure - any improvements are welcome.

For the next pr - if you can attach a screenshot / some proof of it working, that would help accelerate the review on our end!

A successful Docker image result was attached in the first comment, let me know if you need something specified other than that ;)

PeterDaveHello avatar Feb 15 '25 17:02 PeterDaveHello

Missed that, thanks! @PeterDaveHello

krrishdholakia avatar Feb 15 '25 17:02 krrishdholakia