litellm
litellm copied to clipboard
fix: remove --accept-data-loss flag from prisma db push command
Title
Fix remove --accept-data-loss flag from prisma db push command
Relevant issues
This change is critically important because it removes the --accept-data-loss flag from the prisma db push command. By default, this command will now fail or prompt for confirmation if the schema changes could lead to data loss.
Allowing for data loss with no warning is a MAJOR footgun.
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
- [x] I have Added testing in the
tests/litellm/directory, Adding at least 1 test is a hard requirement - see details - [x] I have added a screenshot of my new test passing locally
- [x] My PR passes all unit tests on
make test-unit - [x] My PR's scope is as isolated as possible, it only solves 1 specific problem
Type
🐛 Bug Fix 🚄 Infrastructure
Changes
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| litellm | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 12, 2025 10:40pm |
Hey @skeptrunedev for prod we recommend using prisma migrate - https://docs.litellm.ai/docs/proxy/prod#9-use-prisma-migrate-deploy
After we update our prisma_migration.py file (used by helm) we will also be moving to having that be our default flow.
prisma migrate db push with --accept-data-loss was initially used to avoid having users needing to run cli actions when bumping versions.
Hope the context helps. Closing this PR in favor of the prisma migrate deploy flow - you can run this today with litellm --use_prisma_migrate