litellm icon indicating copy to clipboard operation
litellm copied to clipboard

Honor `include` block when loading config from bucket

Open Bharat23 opened this issue 6 months ago • 2 comments

Title

Honor include block when loading config from S3/GCS bucket https://docs.litellm.ai/docs/proxy/config_management#examples-using-include

Relevant issues

Fixes #10632

Pre-Submission checklist

Please complete all items before asking a LiteLLM maintainer to review your PR

  • [x] I have Added testing in the tests/litellm/ directory, Adding at least 1 test is a hard requirement - see details
  • [x] I have added a screenshot of my new test passing locally
  • [x] My PR passes all unit tests on make test-unit
  • [x] My PR's scope is as isolated as possible, it only solves 1 specific problem

Type

🆕 New Feature ✅ Test

Changes

  • Add process_includes_from_bucket in load_config_utils.py to recursively load include
  • Make get_file_contents_from_s3 async to make it consistent with get_config_file_contents_from_gcs
  • Add moto package to mock and test AWS S3
  • Add test cases for config loading using S3 with include.
Screenshot 2025-05-12 at 12 05 07

Bharat23 avatar May 12 '25 18:05 Bharat23

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2025 11:48pm

vercel[bot] avatar May 12 '25 18:05 vercel[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 12 '25 18:05 CLAassistant

@ishaan-jaff @krrishdholakia can I get a review on this please. Thanks

Bharat23 avatar May 24 '25 23:05 Bharat23

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Aug 23 '25 00:08 github-actions[bot]