litellm icon indicating copy to clipboard operation
litellm copied to clipboard

Remove files generated by FE builds

Open msabramo opened this issue 7 months ago • 6 comments

These probably shouldn't be necessary and are bloating the repo and making it harder to work with the code.

Type

🧹 Refactoring

msabramo avatar Apr 16 '25 17:04 msabramo

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2025 2:42am

vercel[bot] avatar Apr 16 '25 17:04 vercel[bot]

Fixed merge conflict. Consider merging soon if possible to minimize merge conflicts.

@krrishdholakia @ishaan-jaff

msabramo avatar Apr 17 '25 22:04 msabramo

Screenshot 2025-04-17 at 6 26 06 PM

Hey @msabramo the proxy uses this folder

krrishdholakia avatar Apr 18 '25 01:04 krrishdholakia

Can’t you build the FE files in your CI?

Having them in git is very strange and it causes annoyances when working with the code because they easily become modified and then you can’t switch branches without first throwing them away. Much easier to not have them in git.

msabramo avatar Apr 18 '25 15:04 msabramo

Yes - we should.

Since this PR is blocked on that change, we can either close this out for now or refactor this to incorporate the change.

krrishdholakia avatar Apr 18 '25 15:04 krrishdholakia

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 22 '25 21:04 CLAassistant

I am so tired of seeing this message whenever I am working locally: 😢

Screenshot 2025-05-06 at 4 33 54 PM

msabramo avatar May 06 '25 23:05 msabramo

Yes - we should.

Since this PR is blocked on that change, we can either close this out for now or refactor this to incorporate the change.

Taking a stab at seeing if I can get the Dockerfile to build these files, so that they can be removed...

msabramo avatar May 07 '25 01:05 msabramo

Yes - we should. Since this PR is blocked on that change, we can either close this out for now or refactor this to incorporate the change.

Taking a stab at seeing if I can get the Dockerfile to build these files, so that they can be removed...

e454d00f1 is my attempt at doing the build and copying it into the Docker image.

msabramo avatar May 07 '25 02:05 msabramo

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Aug 06 '25 00:08 github-actions[bot]