react-redux-epic icon indicating copy to clipboard operation
react-redux-epic copied to clipboard

Add TypeScript definitions

Open forabi opened this issue 7 years ago • 5 comments

forabi avatar Feb 18 '18 16:02 forabi

Coverage Status

Coverage remained the same at 91.346% when pulling d08d7f9b3d8c9375131cfac8158139435f5223b9 on forabi:patch-1 into da753512b1223aa7b6c2dcb92703d6c1cef8f9f7 on BerkeleyTrue:master.

coveralls avatar Feb 18 '18 16:02 coveralls

Coverage Status

Coverage remained the same at 91.346% when pulling 41ee5fae66b47eef807c0c271bc58d54bd7d1397 on forabi:patch-1 into da753512b1223aa7b6c2dcb92703d6c1cef8f9f7 on BerkeleyTrue:master.

coveralls avatar Feb 18 '18 16:02 coveralls

Is this still required now that there is @types/react-redux-epic?

BerkeleyTrue avatar Mar 28 '18 00:03 BerkeleyTrue

It's up to you. I can send a PR to DefinitelyTyped to deprecate the @types/ package.

forabi avatar Mar 28 '18 10:03 forabi

I don't use typescript. Either way is fine by me. I think a better question is, Would you like this better in the package itself or outside?

BerkeleyTrue avatar Mar 28 '18 21:03 BerkeleyTrue