File description is used like a program name in Windows

[BenjaminRi]

https://stackoverflow.com/questions/15495613/correct-usage-of-the-versioninfo-resource

It is up for debate whether we should put the application name or the description (like I have done in 3cf2f6229950d3fc439b07ec6c6b4f4ffcb54d39) into that field . See also: https://github.com/mxre/winres/pull/43

[zedseven]

I think the application name should be used for FileDescription, since that property is what's used as the program name in Task Manager.

[BenjaminRi]

Yeah, it's weird when a sentence describing what the program does is inserted in places where you'd expect a name (as in the screenshot above). I should probably fix this and also redo the pictures in the README.md.

[BenjaminRi]

I did some more research on this, and other toolkits faced the exact same problem, with the timeline being:

• "Fix" the "bug" that product name is put into FileDescription instead of the description https://github.com/electron-userland/electron-builder/issues/7897
• Windows uses this description as the process name everywhere, people file bugs https://github.com/electron-userland/electron-builder/issues/8599
• The "fix" is reverted: https://github.com/electron-userland/electron-builder/pull/8601

If we were to apply the current logic to ripgrep, it would look like this:

That's clearly wrong, so it has to be fixed here in the winresource crate. The FileDescription must be the package name.

[BenjaminRi]

Fixed in 0921b8aee1bdbe02653ed879c3bc8ca745091cfe (Use package name as FileDescription because Windows uses FileDescription as application name in tools and dialogs.)