Benjamin Bossan

Results 817 comments of Benjamin Bossan

> oh I didn't mean to close the branch, but it seems to have closed while I was merging with the main branch. I guess I'll have to open a...

> I'll review the changes and open a new PR if needed. Sorry to keep bothering you with this. No worries. If the diff on this PR looks good, let...

> maybe `make style` related error was fixed. After applying this command, quite a few files have changed. Is it okay to just push them? Also, what exactly does `make...

> `dropout` variable isn't being used. Should I remove it or just leave it as is? Good catch. I think the correct way is to apply it to `x`, like...

@shahelaojieraozhi Could you please show the exact code that you used with `PeftModel.from_pretrained` and `merge_and_unload` which does not work for you? Please include how you tested that the model does...

It's really hard to say what's going on here, but from the stack trace, my guess would be an issue with `torch.compile` itself. Does the training run without `torch.compile`? Also,...

I'm not sure if the ChatGPT answer can be trusted here, and even if true, as you mentioned, it's not very actionable. What I would try in your situation: 1....

Thanks for reporting back. If you haven't tested it, I'd still recommend upgrading PyTorch, which looks like the most promising solution to me.

> However, I found both encoder and decoder share same LoRA during training. Could you expand on what you mean by that? Maybe it would help to have a separate...

> However, it seems encoder and decoder are totally same and their LoRA parameters are shared. How does that manifest? Could you show what the encoder and decoder look like...