Benjamin Bossan

Results 810 comments of Benjamin Bossan

Thanks for the detailed report and the reproducer. I could get the code to work with a few small changes. Here is the important part: ```python from skorch.helper import SliceDataset...

> * Another workaround is then assign y_sl with another SliceDataset performs np.concatenate by the end of **array**() as this is what happens when calling np.asarray() I think this is...

At this point, it's really hard for me to still follow the discussion as many threads are going on at the same time and the code snippets are not self-contained...

Thanks for summarizing the current state. > * StratifiedKFold is the only one does not work for regression This should be expected, right? Stratification requires that the targets be classes....

Duplicate of https://github.com/huggingface/peft/issues/1831. Please don't create duplicate issues or at the very least reference them to avoid duplicate work on our side.

Thanks for clarifying, that makes sense. I had already shared this concern internally in the past (but got no response :cry:): > Users are reporting issues with Trainer not showing...

Thanks for picking up the TODOs for X-LoRA. > documentation has yet to be added to X-LoRA. I was wondering how I should approach adding this? Typically, for new methods,...

> Perhaps we could include a [Python example of inference with mistral.rs](https://github.com/EricLBuehler/mistral.rs/blob/master/examples/python/xlora_zephyr.py)? It shows significant performance improvement over the Python implementation, and there are packages on PyPi. Yes, it's a...

We're currently in a bit dev starved when it comes PEFT (basically just me), which will hopefully be resolved soon. Could you give an example of what is broken or...

Thanks for the info. I reformatted this and put what sounds like bugs to the top, as they are more important. If you have any further references, like GH issues,...