Fixed: Deprecated API usage

[muhib349]

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Removed deprecated method webOnlyInstantiateImageCodecFromUrl, used createImageCodecFromUrl

:arrow_heading_down: What is the current behavior?

Warning, about to remove webOnlyInstantiateImageCodecFromUrl method

:new: What is the new behavior (if this is a feature change)?

Replaced with createImageCodecFromUrl

:boom: Does this PR introduce a breaking change?

No

:bug: Recommendations for testing

Yes

:memo: Links to relevant issues/docs

#906

:thinking: Checklist before submitting

• [x] All projects build
• [x] Follows style guide lines (code style guide)
• [x] Relevant documentation was updated
• [x] Rebased onto current develop

[erdzan12]

Are there any further points which need to be clarified to merge this?

[amrgetment]

@erdzan12 I am not a repo contributor but I can approve only 😂

[muhib349]

Are there any further points which need to be clarified to merge this?

No, that's the only thing.

[ReinisSprogis]

Would be nice to see this progressing. Any way I can help?

[ReinisSprogis]

Are there any further points which need to be clarified to merge this?

No, that's the only thing.

Any idea why this is not progressing?

[amrgetment]

@renefloor Could you check this PR? Thanks

[MyBlueford16]

any update on this?

[nc-jeni]

+1

When will this be merged and released in a new version? @amorenew @amrgetment @renefloor

[c-seeger]

@renefloor @amorenew any chance this project gets some love?

[jbwise]

This fix being applied would be wonderful. It eliminates an enormous number of errors in image-heavy flutter web sites.

[ReinisSprogis]

Package is abandoned.

[amrgetment]

@amorenew @amrgetment is not a maintainer I just tried to approve but as both accounts are not a collaborator then it won’t affect the PR

[chief-nerd]

We need this merged ... fix is simple and no risk. Needs to go in!

[c-seeger]

@BeMacized or @martijn00 since this repository is part of Baseflow, can you help out here?

[chief-nerd]

Ok awesome -- we have 2 reviews here! --- Now we "just" need to press the "Merge" button and make a release .... Anyone?

[amrgetment]

@mvanbeusekom we need a review and merge for this PR

[ReinisSprogis]

I suggest to use this package instead. https://pub.dev/packages/extended_image

[nc-jeni]

LGTM!

Please tell, which stable release version that will have this fix included? I am not interested in a develop version pulled directly into production code. @mvanbeusekom

[mvanbeusekom]

It has been released in version 1.2.0 of the cached_network_image_web package.

This as a dependency of the cached_network_image, so running flutter pub upgrade should automatically download the new version.

[c-seeger]

@mvanbeusekom this looks wrong to me since the current version released is v3.3.1 which is from december 31, 2023.

I guess the correct tag version would be v3.3.2

Also the v1.2.0 tag is named chached_network_image_web_v1.2.0 which is not a valid semversion

[mvanbeusekom]

Hi @c-seeger,

The cached_network_image package (current version 3.3.1) internally relies on the cached_network_image_web package (current version 1.2.0) to provide support for the web platform.

If you check the pubspec.yaml of the cached_network_image package you'll see the following dependency:

dependencies:
  ...
  cached_network_image_web: ^1.1.1

The ^ syntax here is a version constraint meaning: "depend on the latest version of cached_network_image_web larger or equal to 1.1.1 but smaller then 2.0.0. This means that version 1.2.0 of the cached_network_image_web will automatically be used if you update your dependencies. More details on dependencies and version constraints can be found in the Dart documentation: https://dart.dev/tools/pub/dependencies#version-constraints.

Regarding the tag, this is just a tag and since the repository contains multiple packages we need to differentiate between which version of which package is updated, hence the name of the package in front of the version number in the tag name. If you want to know more of how this works exactly read up on the Federated architecture on the Flutter documentation.

[c-seeger]

Hi @c-seeger,

The cached_network_image package (current version 3.3.1) internally relies on the cached_network_image_web package (current version 1.2.0) to provide support for the web platform.

If you check the pubspec.yaml of the cached_network_image package you'll see the following dependency:

dependencies:
  ...
  cached_network_image_web: ^1.1.1

The ^ syntax here is a version constraint meaning: "depend on the latest version of cached_network_image_web larger or equal to 1.1.1 but smaller then 2.0.0. This means that version 1.2.0 of the cached_network_image_web will automatically be used if you update your dependencies. More details on dependencies and version constraints can be found in the Dart documentation: https://dart.dev/tools/pub/dependencies#version-constraints.

Regarding the tag, this is just a tag and since the repository contains multiple packages we need to differentiate between which version of which package is updated, hence the name of the package in front of the version number in the tag name. If you want to know more of how this works exactly read up on the Federated architecture on the Flutter documentation.

Awesome thank you for clarifying this :+1: