flutter-permission-handler icon indicating copy to clipboard operation
flutter-permission-handler copied to clipboard

Published 20 hours ago • verified publisher icon Baseflow

Remove unused constant

Open spkersten opened this issue 2 years ago • 2 comments

🏗 Enhancement Proposal

Remove unused PERMISSION_PHOTOS_ADD_ONLY constant: https://github.com/Baseflow/flutter-permission-handler/blob/2e47f05ae9dabee2bc671166301aa948259b39f2/permission_handler_apple/ios/Classes/PermissionHandlerEnums.h#L60

It is confusing as it suggest it should be used for addOnly photos permission, while it does nothing and PERMISSION_PHOTOS is needed.

Platforms affected (mark all that apply)

  • [x] :iphone: iOS
  • [ ] :robot: Android

spkersten avatar Jan 30 '23 12:01 spkersten

Dear @spkersten,

This seems like a good improvement. I'll label this as an enhancement.

Kind regards,

TimHoogstrate avatar Jul 25 '23 07:07 TimHoogstrate

With PERMISSION_PHOTOS_ADD_ONLY=1, Permission.photosAddOnly.status keeps returning denied.

It looks like PERMISSION_PHOTOS_ADD_ONLY has no effect at all and actually, PERMISSION_PHOTOS needs to be enabled.

https://github.com/Baseflow/flutter-permission-handler/blob/842761c2aae2368ddd4811b3b12ede28ed2c8d62/permission_handler_apple/ios/Classes/strategies/PhotoPermissionStrategy.h#L9-L15

After that, Permission.photosAddOnly.status returns the correct value

kumasan3 avatar Feb 20 '24 13:02 kumasan3