flutter-permission-handler icon indicating copy to clipboard operation
flutter-permission-handler copied to clipboard

migrate to package:web

Open raldhafiri opened this issue 1 year ago • 7 comments

Migrated to package:web, meaning that it now supports WASM!

Fix #1302

raldhafiri avatar Apr 09 '24 20:04 raldhafiri

I'd just like to add my support for this. In my reasonably complex application, this is the only package preventing us from compiling to wasm. I have reviewed this patch and it looks correct to me. Is there something that is holding this up? Thanks!

james-pellow avatar Apr 29 '24 18:04 james-pellow

I'd just like to add my support for this. In my reasonably complex application, this is the only package preventing us from compiling to wasm. I have reviewed this patch and it looks correct to me. Is there something that is holding this up? Thanks!

I would recommend you to create pubspec_overrides.yaml and use it until it get merged or fork my repo I know its not the best solution but hopefully it will be merged soon to support WASM

dependency_overrides:
  permission_handler_html:
    git:
      url: https://github.com/raldhafiri/flutter-permission-handler.git
      ref: main
      path: permission_handler_html

raldhafiri avatar Apr 29 '24 18:04 raldhafiri

Thanks for the great PR. Can't wait to see it merged.

How about updating index.html to the template added in flutter 3.22.0? So we can test the build for wasm and it will be easier to make sure it works.

koji-1009 avatar May 18 '24 11:05 koji-1009

Bump

Padi142 avatar Jun 04 '24 19:06 Padi142

can you merge it faster and deploy on pub.dev? @james-pellow @koji-1009 @Padi142 @bramp

hasanm08 avatar Jun 11 '24 09:06 hasanm08

@raldhafiri I have created a commit to update the example project with the flutter 3.22 template. Could you please check the commit? If necessary, I will create a PR for the branch you are developing. Thanks.

https://github.com/koji-1009/flutter-permission-handler/commit/b2f97273fb2bf2f91725b75ef2a168f5bd1a1739

koji-1009 avatar Jun 11 '24 12:06 koji-1009

@mvanbeusekom @gmackall Please review this

MominRaza avatar Jun 28 '24 17:06 MominRaza

Can someone merge this please? :)

Brada-Groep avatar Jul 26 '24 08:07 Brada-Groep

On popular demand, this PR has just been merged and published.

Run flutter pub upgrade permission_handler_html to download the latest version in your project.

mvanbeusekom avatar Jul 26 '24 09:07 mvanbeusekom