flutter-geolocator icon indicating copy to clipboard operation
flutter-geolocator copied to clipboard

NMEA Messages on Android

Open rickcasson opened this issue 3 years ago • 4 comments

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Adds ability to listen to NMEA messages on Android.

:memo: Links to relevant issues/docs

Closes #561, closes #605, closes #819 This builds upon #605 and #819 using the updated project structure. I understand that @mvanbeusekom is working on a different approach, but this may function as a workaround for now. Until this is merged, you will need to include this in your project's pubspec.yaml:

dependency_overrides:
  geolocator:
    git:
      url: git://github.com/rickcasson/flutter-geolocator.git
      path: geolocator
      ref: nmea
  geolocator_platform_interface:
    git:
      url: git://github.com/rickcasson/flutter-geolocator.git
      path: geolocator_platform_interface
      ref: nmea
  geolocator_android:
    git:
      url: git://github.com/rickcasson/flutter-geolocator.git
      path: geolocator_android
      ref: nmea

:thinking: Checklist before submitting

  • [x] I made sure all projects build.
  • [x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • [x] I updated CHANGELOG.md to add a description of the change.
  • [x] I followed the style guide lines (code style guide).
  • [x] I updated the relevant documentation.
  • [x] I rebased onto current main.

rickcasson avatar Jan 06 '22 01:01 rickcasson

Codecov Report

Base: 94.11% // Head: 100.00% // Increases project coverage by +5.88% :tada:

Coverage data is based on head (582ef8f) compared to base (8399525). Patch coverage: 100.00% of modified lines in pull request are covered.

:exclamation: Current head 582ef8f differs from pull request most recent head f95c494. Consider uploading reports for the commit f95c494 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #932      +/-   ##
===========================================
+ Coverage   94.11%   100.00%   +5.88%     
===========================================
  Files           5        20      +15     
  Lines         221       448     +227     
===========================================
+ Hits          208       448     +240     
+ Misses         13         0      -13     
Impacted Files Coverage Δ
geolocator/lib/geolocator.dart 100.00% <100.00%> (ø)
geolocator_android/lib/src/geolocator_android.dart 100.00% <100.00%> (+2.10%) :arrow_up:
.../src/errors/nmea_already_subscribed_exception.dart 100.00% <100.00%> (ø)
...nterface/lib/src/errors/nmea_update_exception.dart 100.00% <100.00%> (ø)
...terface/lib/src/geolocator_platform_interface.dart 100.00% <100.00%> (ø)
...src/implementations/method_channel_geolocator.dart 100.00% <100.00%> (ø)
...latform_interface/lib/src/models/nmea_message.dart 100.00% <100.00%> (ø)
geolocator_apple/lib/src/types/apple_settings.dart
geolocator_apple/lib/src/geolocator_apple.dart
...or_platform_interface/lib/src/models/position.dart 100.00% <0.00%> (ø)
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jan 06 '22 03:01 codecov[bot]

I have tested this feature and it's working very well.

I think in pubspec.yaml should be:

dependency_overrides:
  geolocator:
    git:
      url: git://github.com/rickcasson/flutter-geolocator.git
      path: geolocator
      ref: nmea
  geolocator_platform_interface:
    git:
      url: git://github.com/rickcasson/flutter-geolocator.git
      path: geolocator_platform_interface
      ref: nmea
  geolocator_android:
    git:
      url: git://github.com/rickcasson/flutter-geolocator.git
      path: geolocator_android
      ref: nmea

memarv avatar Mar 21 '22 08:03 memarv

Hi @mvanbeusekom, I'm not sure what your plans are with NMEA message streaming in this plugin, but I cleaned up this PR and brought it back up to date with the main branch in hopes in might get merged or helps your other development plans. Please let me know if there is anything else I can do to help!

rickcasson avatar May 15 '22 20:05 rickcasson

Hey @mvanbeusekom, I brought this PR back in line with main and targeted the latest release of the baseflow_plugin_template to get around the deprecation errors, but wondering if you would like me to separate this into multiple PRs or if the internal dependency overrides can just be removed before this possibly gets merged?

rickcasson avatar Sep 14 '22 17:09 rickcasson