flutter-geolocator
flutter-geolocator copied to clipboard
Export AndroidResource class
:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Export AndroidResource class from the geolocator and geolocator_android libraries to allow configuring the icon of the notifications
:arrow_heading_down: What is the current behavior?
AndroidResource class is not exported, so there is no way to configure the notificationIcon of the ForegroundNotificationConfig class.
:new: What is the new behavior (if this is a feature change)?
Users can use the AndroidResource class to configure the notificationIcon of the ForegroundNotificationConfig class.
:boom: Does this PR introduce a breaking change?
No
:bug: Recommendations for testing
NA
:memo: Links to relevant issues/docs
https://github.com/Baseflow/flutter-geolocator/issues/1011
:thinking: Checklist before submitting
- [x] I made sure all projects build.
- [x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
- [x] I updated CHANGELOG.md to add a description of the change.
- [x] I followed the style guide lines (code style guide).
- [x] I updated the relevant documentation.
- [x] I rebased onto current
master.
Codecov Report
Base: 90.29% // Head: 98.29% // Increases project coverage by +7.99% :tada:
Coverage data is based on head (
1ecbb1c) compared to base (c8a5ef6). Patch has no changes to coverable lines.
Additional details and impacted files
@@ Coverage Diff @@
## main #1105 +/- ##
==========================================
+ Coverage 90.29% 98.29% +7.99%
==========================================
Files 2 3 +1
Lines 103 117 +14
==========================================
+ Hits 93 115 +22
+ Misses 10 2 -8
| Impacted Files | Coverage Δ | |
|---|---|---|
| geolocator_apple/lib/src/geolocator_apple.dart | ||
| geolocator_apple/lib/src/types/apple_settings.dart | ||
| geolocator_android/lib/src/geolocator_android.dart | 97.89% <0.00%> (ø) |
|
| ...tor_android/lib/src/types/foreground_settings.dart | 100.00% <0.00%> (ø) |
|
| ...ocator_android/lib/src/types/android_settings.dart | 100.00% <0.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
I'm not sure if I have to bump versions in both geolocator_android and geolocator packages. Let me know if should just bump one of them instead? Or maybe I should first create a PR for geolocator_android, get it merged and then create a new one for geolocator?
Hi @tamizhgeek,
Due to holiday I haven't been able to review this PR earlier. Best would be to split this PR up into 2 pull requests:
- First a PR updating the geolocator_android package (including a updated version number and changelog entry);
- Second (after the first is published) a PR updating the geolocator package.
Would you be able to help out to accomplish this?
Hey @mvanbeusekom thanks for the commend. Yes that sounds good to me. Will take care of it.
Hey guys. Is there any plan to merge the fix?
Thank you very much in advance :)
Apologies for the delay @mvanbeusekom
For now, it seems like the build is failing for reasons not related to the changes made in this PR. I will check back in a while and see if this is a temporary issue.
@mvanbeusekom all checks have passed now. I think this can be merged, please take a look.
Hi @tamizhgeek,
Thank you for all your work on this PR, I have just published the geolocator_android package containing this update to pub.dev (see https://pub.dev/packages/geolocator_android).
Would you mind creating the second PR to expose the AndroidResource through the geolocator package?
@mvanbeusekom Yes sure. Here it is: https://github.com/Baseflow/flutter-geolocator/pull/1136