flutter-geocoding
flutter-geocoding copied to clipboard
Baseflow
Add formattedAddress
:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Enhancement: added 'formattedAddress' Android is just as like #55 , but iOS fixed.
:arrow_heading_down: What is the current behavior?
Formatted address does not provided. It's very useful on several locales. (In US. address represented as "street city state postalcode country", but in Japan. it represented as "postalcode prefecture city addressnumber" It's so complicated. We should leave it to OS.)
:new: What is the new behavior (if this is a feature change)?
Formatted address are provided.
:boom: Does this PR introduce a breaking change?
Perhaps in edge case(serializing or something like this), because member has been added.
:bug: Recommendations for testing
I tested on iOS 14 and Android 11. I don't have iOS 9 devices. If you have, please.
:memo: Links to relevant issues/docs
Pull req. #55
:thinking: Checklist before submitting
- [x] I made sure all projects build.
- [x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
- [x] I updated CHANGELOG.md to add a description of the change. (Just bumped, if breaking changes are so heavy, I'll bump it to 2.1.0)
- [x] I followed the style guide lines (code style guide).
- [x] I updated the relevant documentation. (Sorry, I didn't find it out.)
- [x] I rebased onto current
master.
@mvanbeusekom is there something holding this PR back? Would like to merge this too.
There is not one standard of formatting the address and different users/ applications have different needs to display the address. Therefore the suggested approach is to format the address based on the different elements returned by the plugin.
We feel adding this method will add extra maintenance difficulties and will not merge this PR.
Thank you for the review! I understand the decision. However, for a bit more information, this approach does not format the address and leaves it to the respective operating system behaviour. For the same reason that you pointed out.