omi icon indicating copy to clipboard operation
omi copied to clipboard

feat: Custom Audio Player [#381]

Open SHAH-JI opened this issue 1 year ago • 23 comments

Changes:

  • Initial Implementation of Custom Audio Player with 3 sample audio files
  • Main Screen changed to AudioPlayerTest for testing purposes

SHAH-JI avatar Jul 02 '24 16:07 SHAH-JI

Hi @SHAH-JI please upload a video showing the functionality please. Also, if it's initial implementation, created instead a Draft PR. Thanks

josancamon19 avatar Jul 03 '24 07:07 josancamon19

to @josancamon19 Please check the demo below and let me know, if any changes are required. Thanks. https://github.com/BasedHardware/Friend/assets/25644067/28c11495-c322-49b7-8da1-43fac073d8b4

SHAH-JI avatar Jul 03 '24 16:07 SHAH-JI

It looks good in terms of functionality, not in terms of UI. @SHAH-JI

josancamon19 avatar Jul 03 '24 20:07 josancamon19

to @josancamon19 Can you share the UI part which needs improvement?

SHAH-JI avatar Jul 04 '24 03:07 SHAH-JI

to @josancamon19 Here are some UI improvements and also added playback speed change.

https://github.com/BasedHardware/Friend/assets/25644067/58cfed02-b0a0-43ae-b42b-b2b4b2417e8b

SHAH-JI avatar Jul 04 '24 16:07 SHAH-JI

I think this looks great, please create the proper PR for it! @SHAH-JI

josancamon19 avatar Jul 05 '24 03:07 josancamon19

to @josancamon19 Sure, I have moved the PR from draft to Ready for Review, please check.

SHAH-JI avatar Jul 05 '24 03:07 SHAH-JI

@SHAH-JI I don't see any changes to memory_detail component? where did you put the new component?

josancamon19 avatar Jul 05 '24 08:07 josancamon19

to @josancamon19 The new component is in lib/pages/memories/widget/custom_audio_player.dart

SHAH-JI avatar Jul 05 '24 15:07 SHAH-JI

Perfect, please include it on memory detail @SHAH-JI

josancamon19 avatar Jul 06 '24 08:07 josancamon19

to @josancamon19 Following changes are done:

  1. Module added in memory_detail
  2. Effective commenting for better understanding
  3. Added Support for temporary cache directory (app storage files)

SHAH-JI avatar Jul 06 '24 16:07 SHAH-JI

CleanShot 2024-07-06 at 11 51 47@2x I don't understand what's this.

This should play of course the audio from the memory recording

josancamon19 avatar Jul 06 '24 18:07 josancamon19

to @josancamon19 Please pull the new changes, with my 2nd last commit I have added the support for the file in cache (Audio from memory recording). On CustomAudioPlayer initialization, you just need to provide the FileType and it will start working.

SHAH-JI avatar Jul 07 '24 03:07 SHAH-JI

to @josancamon19 Also, the AudioPlayerTestPage is an example widget on how to use different files types. It is not part of the Custom Audio Player UI.

SHAH-JI avatar Jul 07 '24 03:07 SHAH-JI

Please include the component as part of the UI of memory_detail. with memory.recordingPath field. Uploading CleanShot 2024-07-06 at 23.31.56@2x.png…

josancamon19 avatar Jul 07 '24 06:07 josancamon19

to @josancamon19 AudioPlayer has to be added on the Summary tab? If yes can you also point out the position?

SHAH-JI avatar Jul 08 '24 04:07 SHAH-JI

to @josancamon19 Please check the screen and let me know if there are any changes to be done. Thanks https://github.com/BasedHardware/Friend/assets/113975718/fe78aee7-1eaa-46cd-acac-bdd89fc77f61

SHAH-JI avatar Jul 09 '24 04:07 SHAH-JI

to @josancamon19 I am waiting for your response.

mshahjahan-mufin avatar Jul 11 '24 03:07 mshahjahan-mufin

This doesn't look like the sample shown.

  1. How is this going to go on the list item of the memory, that makes absolute nonsense.
  2. Looks terrible in memory detail.

josancamon19 avatar Jul 15 '24 05:07 josancamon19

to @josancamon19 Now it same like the sample and remove the Audio Player from list item. Please check the below screenshot: WhatsApp Image 2024-07-15 at 13 12 29

SHAH-JI avatar Jul 15 '24 08:07 SHAH-JI

Share a video please, and tell me if this seems like a good UI.

josancamon19 avatar Jul 16 '24 00:07 josancamon19

to @josancamon19

  1. Here is the app video, please let me know if there are any changes to be made.
  2. As for the UI, in my opinion it is good as of now.
  3. Please make the google-services.json and firebase_options.dart files available. It makes difficult to work on the project without them.

Video:

https://github.com/user-attachments/assets/c52926e6-af03-46f4-9423-43a3fcaa7ebc

SHAH-JI avatar Jul 16 '24 03:07 SHAH-JI

to @kodjima33 Can you please check this comment and let me know if there are any changes: https://github.com/BasedHardware/Friend/pull/399#issuecomment-2229926052

SHAH-JI avatar Aug 07 '24 16:08 SHAH-JI

Discarded

josancamon19 avatar Aug 29 '24 08:08 josancamon19