omi
omi copied to clipboard
feat: Custom Audio Player [#381]
Changes:
- Initial Implementation of Custom Audio Player with 3 sample audio files
- Main Screen changed to AudioPlayerTest for testing purposes
Hi @SHAH-JI please upload a video showing the functionality please. Also, if it's initial implementation, created instead a Draft PR. Thanks
to @josancamon19 Please check the demo below and let me know, if any changes are required. Thanks. https://github.com/BasedHardware/Friend/assets/25644067/28c11495-c322-49b7-8da1-43fac073d8b4
It looks good in terms of functionality, not in terms of UI. @SHAH-JI
to @josancamon19 Can you share the UI part which needs improvement?
to @josancamon19 Here are some UI improvements and also added playback speed change.
https://github.com/BasedHardware/Friend/assets/25644067/58cfed02-b0a0-43ae-b42b-b2b4b2417e8b
I think this looks great, please create the proper PR for it! @SHAH-JI
to @josancamon19 Sure, I have moved the PR from draft to Ready for Review, please check.
@SHAH-JI I don't see any changes to memory_detail component? where did you put the new component?
to @josancamon19 The new component is in lib/pages/memories/widget/custom_audio_player.dart
Perfect, please include it on memory detail @SHAH-JI
to @josancamon19 Following changes are done:
- Module added in memory_detail
- Effective commenting for better understanding
- Added Support for temporary cache directory (app storage files)
I don't understand what's this.
This should play of course the audio from the memory recording
to @josancamon19 Please pull the new changes, with my 2nd last commit I have added the support for the file in cache (Audio from memory recording). On CustomAudioPlayer initialization, you just need to provide the FileType and it will start working.
to @josancamon19
Also, the AudioPlayerTestPage is an example widget on how to use different files types. It is not part of the Custom Audio Player UI.
Please include the component as part of the UI of memory_detail. with memory.recordingPath field.
to @josancamon19 AudioPlayer has to be added on the Summary tab? If yes can you also point out the position?
to @josancamon19 Please check the screen and let me know if there are any changes to be done. Thanks https://github.com/BasedHardware/Friend/assets/113975718/fe78aee7-1eaa-46cd-acac-bdd89fc77f61
to @josancamon19 I am waiting for your response.
This doesn't look like the sample shown.
- How is this going to go on the list item of the memory, that makes absolute nonsense.
- Looks terrible in memory detail.
to @josancamon19
Now it same like the sample and remove the Audio Player from list item. Please check the below screenshot:
Share a video please, and tell me if this seems like a good UI.
to @josancamon19
- Here is the app video, please let me know if there are any changes to be made.
- As for the UI, in my opinion it is good as of now.
- Please make the
google-services.jsonandfirebase_options.dartfiles available. It makes difficult to work on the project without them.
Video:
https://github.com/user-attachments/assets/c52926e6-af03-46f4-9423-43a3fcaa7ebc
to @kodjima33 Can you please check this comment and let me know if there are any changes: https://github.com/BasedHardware/Friend/pull/399#issuecomment-2229926052
Discarded