obs-websocket-dotnet icon indicating copy to clipboard operation
obs-websocket-dotnet copied to clipboard

Published 20 hours ago • verified publisher icon BarRaider

v5 Request - Add interface for `OBSWebsocket` so it can be mocked easier in testing

Open grofit opened this issue 3 years ago • 1 comments

Issue Type

  • Feature Request

Describe the issue Currently there is no interface wrapping the OBSWebsocket class so in unit tests you are forced to new up this type, however there is no reason why it cant have an interface added to allow easier mocking.

Additional context I am happy enough to do a PR to add this in as its a few seconds job with rider/resharper to add an interface, but would rather this happened after #106 has been dealt with so the interface will be in line with that.

If you are against it I can kinda work around it my side by wrapping everything or a facade inheritance class that acts as the interface entry point but it seems like this has 0 downsides and could benefit others.

grofit avatar Sep 13 '22 15:09 grofit

I have raise a PR for this, but I thought I had put it against #99 but turns out im an idiot, anyway the pr is #110

grofit avatar Sep 19 '22 14:09 grofit