Babylon.js icon indicating copy to clipboard operation
Babylon.js copied to clipboard

update camera's target when the mouse wheel is rolling for zoomtomouselocation

Open ecojust opened this issue 1 year ago • 5 comments

https://forum.babylonjs.com/t/zoomtomouselocation-issue-after-camera-settarget/46716

fixed bug : zoomtomouselocation-issue-after-camera-settarget

ecojust avatar Dec 27 '23 17:12 ecojust

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat avatar Dec 27 '23 17:12 bjsplat

Snapshot stored with reference name: refs/pull/14653/merge

Test environment: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14653/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14653/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/14653/merge https://sandbox.babylonjs.com/?snapshot=refs/pull/14653/merge https://gui.babylonjs.com/?snapshot=refs/pull/14653/merge https://nme.babylonjs.com/?snapshot=refs/pull/14653/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/14653/merge#BCU1XR#0

bjsplat avatar Dec 27 '23 17:12 bjsplat

Thanks for the PR, but please be patient for the review as the team is on Christmas vacation.

Popov72 avatar Dec 27 '23 18:12 Popov72

I do not think this is the right fix but I am terrible with Cameras :-)

Could we not update some of the parameters only once when we actually sets the new target ?

The new change is pretty heavy to run every frame.

yeah , u are right I have used a variable to limit the occurrence of this behavior (_targetSetManually)

ecojust avatar Jan 03 '24 12:01 ecojust

Marking as draft. I think that this needs a bit more work before we can merge it.

PolygonalSun avatar Jan 03 '24 21:01 PolygonalSun

This pull request has been marked as stale because it has been inactive for more than 14 days. Please update to "unstale".

github-actions[bot] avatar Mar 14 '24 00:03 github-actions[bot]

This pull request has been marked as stale because it has been inactive for more than 14 days. Please update to "unstale".

github-actions[bot] avatar Mar 30 '24 00:03 github-actions[bot]

Closing with no activity

deltakosh avatar Apr 02 '24 22:04 deltakosh