update camera's target when the mouse wheel is rolling for zoomtomouselocation
https://forum.babylonjs.com/t/zoomtomouselocation-issue-after-camera-settarget/46716
fixed bug : zoomtomouselocation-issue-after-camera-settarget
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). To prevent this PR from going to the changelog marked it with the "skip changelog" label.
Snapshot stored with reference name: refs/pull/14653/merge
Test environment: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14653/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14653/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/14653/merge https://sandbox.babylonjs.com/?snapshot=refs/pull/14653/merge https://gui.babylonjs.com/?snapshot=refs/pull/14653/merge https://nme.babylonjs.com/?snapshot=refs/pull/14653/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/14653/merge#BCU1XR#0
Thanks for the PR, but please be patient for the review as the team is on Christmas vacation.
I do not think this is the right fix but I am terrible with Cameras :-)
Could we not update some of the parameters only once when we actually sets the new target ?
The new change is pretty heavy to run every frame.
yeah , u are right I have used a variable to limit the occurrence of this behavior (_targetSetManually)
Marking as draft. I think that this needs a bit more work before we can merge it.
This pull request has been marked as stale because it has been inactive for more than 14 days. Please update to "unstale".
This pull request has been marked as stale because it has been inactive for more than 14 days. Please update to "unstale".
Closing with no activity