Babylon.js icon indicating copy to clipboard operation
Babylon.js copied to clipboard

TargetCamera: Check for changes on all axes when handling rotations

Open PolygonalSun opened this issue 2 years ago • 8 comments

A user found in the forum that changes to the TargetCamera's rotationQuaternion would have no effect if there was no change to the Z-axis. This PR changes the logic to check for any changes to the rotationQuaternion and rotation vector. If any exist, things will be updated accordingly.

Forum Post: https://forum.babylonjs.com/t/targetcamera-rotationquaternion-bug/39422

PolygonalSun avatar Apr 04 '23 23:04 PolygonalSun

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat avatar Apr 04 '23 23:04 bjsplat

Snapshot stored with reference name: refs/pull/13700/merge

Test environment: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13700/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13700/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/13700/merge https://sandbox.babylonjs.com/?snapshot=refs/pull/13700/merge https://gui.babylonjs.com/?snapshot=refs/pull/13700/merge https://nme.babylonjs.com/?snapshot=refs/pull/13700/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/13700/merge#BCU1XR#0

bjsplat avatar Apr 05 '23 00:04 bjsplat

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13700/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

bjsplat avatar Apr 05 '23 22:04 bjsplat

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13700/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

bjsplat avatar Apr 05 '23 22:04 bjsplat

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13700/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

bjsplat avatar Apr 06 '23 05:04 bjsplat

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13700/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

bjsplat avatar Apr 06 '23 05:04 bjsplat

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13700/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

bjsplat avatar Apr 18 '23 00:04 bjsplat

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13700/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

bjsplat avatar Apr 18 '23 00:04 bjsplat

@PolygonalSun, is this still relevant ?

sebavan avatar May 15 '23 19:05 sebavan

@PolygonalSun, is this still relevant ?

The solution needs to be reworked. Closing for now. I'll reopen it when I've found a proper solution.

PolygonalSun avatar May 15 '23 19:05 PolygonalSun