Babylon.js icon indicating copy to clipboard operation
Babylon.js copied to clipboard

Add uv transforms to thininstances

Open unicomp21 opened this issue 3 years ago • 8 comments

Add uv transforms to thininstances.

unicomp21 avatar Oct 12 '22 14:10 unicomp21

Please reference the forum post

deltakosh avatar Oct 12 '22 14:10 deltakosh

https://forum.babylonjs.com/t/thin-instances-uv-attribute-weird-result/34061/14?u=unicomp21

unicomp21 avatar Oct 12 '22 15:10 unicomp21

I am wondering if it should be supported by default or wether a material plugin only ? This looks like a pretty edge case feature and I am not sure we should embed it by default ?

sebavan avatar Oct 12 '22 15:10 sebavan

I think it could be edge ... until it's not. The potential here for a non-repeating (thanks to variation in texture), volume filling primitive, is pretty significant.

unicomp21 avatar Oct 13 '22 10:10 unicomp21

By edge case I mean not everybody will use it and thus I d prefer it to be on demand to not increase the size of the code in most of the experiences.

sebavan avatar Oct 13 '22 14:10 sebavan

How much of a size increase will there be?

unicomp21 avatar Oct 13 '22 14:10 unicomp21

not sure but we could say the same for any small features resulting in overall big additions :-)

I am not saying we should not add the feature, but I d rather keep it as a material plugin that people need to import in order to benefit from it instead of embedding it in the material.

sebavan avatar Oct 14 '22 15:10 sebavan

This issue has been automatically staled because it has been inactive for more than 14 days. Please update to "unstale".

github-actions[bot] avatar Mar 27 '24 00:03 github-actions[bot]

https://forum.babylonjs.com/t/add-uv-transforms-to-thininstances/52140

thomlucc avatar Jul 17 '24 20:07 thomlucc