Babylon.js icon indicating copy to clipboard operation
Babylon.js copied to clipboard

Move from @hidden to @internal

Open RaananW opened this issue 3 years ago • 4 comments

Setting as Draft for now to check side effects There shouldn't be any, just need to be 100% sure :-)

RaananW avatar Sep 20 '22 18:09 RaananW

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). To prevent this PR from going to the changelog marked it with the "skip changelog" label.

azure-pipelines[bot] avatar Sep 20 '22 18:09 azure-pipelines[bot]

Snapshot stored with reference name: refs/pull/12999/merge

Test environment: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12999/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12999/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12999/merge https://sandbox.babylonjs.com/?snapshot=refs/pull/12999/merge https://gui.babylonjs.com/?snapshot=refs/pull/12999/merge https://nme.babylonjs.com/?snapshot=refs/pull/12999/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12999/merge#BCU1XR#0

azure-pipelines[bot] avatar Sep 20 '22 19:09 azure-pipelines[bot]

Is it not messing the playground checks for typings ? I remember we had special rules there but can not remember if there were for @hidden or only removing _ functions.

sebavan avatar Sep 20 '22 20:09 sebavan

Is it not messing the playground checks for typings ? I remember we had special rules there but can not remember if there were for @hidden or only removing _ functions.

I could not find any reference of hidden in the playground, and have checked the playground - it doesn't show any hidden/internal options.

RaananW avatar Sep 21 '22 10:09 RaananW

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12999/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

azure-pipelines[bot] avatar Sep 21 '22 16:09 azure-pipelines[bot]