Babylon.js icon indicating copy to clipboard operation
Babylon.js copied to clipboard

Created an offset when pasting controls

Open amritanarasimhan opened this issue 3 years ago • 4 comments

When controls were pasted, they were visually directly on top of each other. Now, there is a visible change on screen when controls are pasted due to the offset

amritanarasimhan avatar Aug 08 '22 18:08 amritanarasimhan

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). To prevent this PR from going to the changelog marked it with the "skip changelog" label.

azure-pipelines[bot] avatar Aug 09 '22 20:08 azure-pipelines[bot]

Snapshot stored with reference name: refs/pull/12850/merge

Test environment: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12850/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12850/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12850/merge https://sandbox.babylonjs.com/?snapshot=refs/pull/12850/merge https://gui.babylonjs.com/?snapshot=refs/pull/12850/merge https://nme.babylonjs.com/?snapshot=refs/pull/12850/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12850/merge#BCU1XR#0

azure-pipelines[bot] avatar Aug 09 '22 21:08 azure-pipelines[bot]

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). To prevent this PR from going to the changelog marked it with the "skip changelog" label.

azure-pipelines[bot] avatar Aug 09 '22 22:08 azure-pipelines[bot]

Snapshot stored with reference name: refs/pull/12850/merge

Test environment: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12850/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12850/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12850/merge https://sandbox.babylonjs.com/?snapshot=refs/pull/12850/merge https://gui.babylonjs.com/?snapshot=refs/pull/12850/merge https://nme.babylonjs.com/?snapshot=refs/pull/12850/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12850/merge#BCU1XR#0

azure-pipelines[bot] avatar Aug 09 '22 22:08 azure-pipelines[bot]

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). To prevent this PR from going to the changelog marked it with the "skip changelog" label.

azure-pipelines[bot] avatar Aug 10 '22 17:08 azure-pipelines[bot]

Snapshot stored with reference name: refs/pull/12850/merge

Test environment: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12850/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12850/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12850/merge https://sandbox.babylonjs.com/?snapshot=refs/pull/12850/merge https://gui.babylonjs.com/?snapshot=refs/pull/12850/merge https://nme.babylonjs.com/?snapshot=refs/pull/12850/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12850/merge#BCU1XR#0

azure-pipelines[bot] avatar Aug 10 '22 17:08 azure-pipelines[bot]

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). To prevent this PR from going to the changelog marked it with the "skip changelog" label.

azure-pipelines[bot] avatar Aug 11 '22 00:08 azure-pipelines[bot]

Snapshot stored with reference name: refs/pull/12850/merge

Test environment: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12850/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12850/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12850/merge https://sandbox.babylonjs.com/?snapshot=refs/pull/12850/merge https://gui.babylonjs.com/?snapshot=refs/pull/12850/merge https://nme.babylonjs.com/?snapshot=refs/pull/12850/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12850/merge#BCU1XR#0

azure-pipelines[bot] avatar Aug 11 '22 00:08 azure-pipelines[bot]

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). To prevent this PR from going to the changelog marked it with the "skip changelog" label.

azure-pipelines[bot] avatar Aug 12 '22 18:08 azure-pipelines[bot]

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). To prevent this PR from going to the changelog marked it with the "skip changelog" label.

azure-pipelines[bot] avatar Aug 12 '22 18:08 azure-pipelines[bot]

Snapshot stored with reference name: refs/pull/12850/merge

Test environment: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12850/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12850/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12850/merge https://sandbox.babylonjs.com/?snapshot=refs/pull/12850/merge https://gui.babylonjs.com/?snapshot=refs/pull/12850/merge https://nme.babylonjs.com/?snapshot=refs/pull/12850/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12850/merge#BCU1XR#0

azure-pipelines[bot] avatar Aug 12 '22 19:08 azure-pipelines[bot]

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). To prevent this PR from going to the changelog marked it with the "skip changelog" label.

azure-pipelines[bot] avatar Aug 12 '22 19:08 azure-pipelines[bot]

Snapshot stored with reference name: refs/pull/12850/merge

Test environment: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12850/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12850/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12850/merge https://sandbox.babylonjs.com/?snapshot=refs/pull/12850/merge https://gui.babylonjs.com/?snapshot=refs/pull/12850/merge https://nme.babylonjs.com/?snapshot=refs/pull/12850/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12850/merge#BCU1XR#0

azure-pipelines[bot] avatar Aug 12 '22 19:08 azure-pipelines[bot]

and to remove the added getter as they are not required :-)

 public get currTop() {
        return this._currTop;
    }
    public get currLeft() {
        return this._currLeft;
    }
    public set currTop(val: number) {
        this._currTop = val;
    }
    public set currLeft(val: number) {
        this._currLeft = val;
    }

sebavan avatar Aug 15 '22 19:08 sebavan

You now just need to merge with master :-)

sebavan avatar Aug 15 '22 21:08 sebavan

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). To prevent this PR from going to the changelog marked it with the "skip changelog" label.

azure-pipelines[bot] avatar Aug 15 '22 21:08 azure-pipelines[bot]

Snapshot stored with reference name: refs/pull/12850/merge

Test environment: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12850/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12850/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12850/merge https://sandbox.babylonjs.com/?snapshot=refs/pull/12850/merge https://gui.babylonjs.com/?snapshot=refs/pull/12850/merge https://nme.babylonjs.com/?snapshot=refs/pull/12850/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12850/merge#BCU1XR#0

azure-pipelines[bot] avatar Aug 15 '22 21:08 azure-pipelines[bot]