SuperiorSkyblock2 icon indicating copy to clipboard operation
SuperiorSkyblock2 copied to clipboard

Players can no longer use /is recalc | /is level

Open LuluxClient opened this issue 3 years ago • 11 comments

Minecraft's Version

1.18.2

Plugin's Version

1.11.1.766

Describe the bug

When a players tries to do /is recalc after X seconds it's sending an error mesage saying the request expired: https://youtu.be/1AMWjGsxoMg

To Reproduce

do /is recalc with a huge island with 200 players and lot of blocks and spawners and 100k+ stacked blocks.

Additional Information

No response

LuluxClient avatar Aug 18 '22 14:08 LuluxClient

Used to take 1s to do it but now everyone can no longer do it even changing the recalc-task-timeout: to 0 it will take 10y and it won't do anything

LuluxClient avatar Aug 18 '22 14:08 LuluxClient

It takes too long to process the recalc, therefore it fails. You can configure the timeout to be whatever you want it to be.

What's the bug I don't understand

OmerBenGera avatar Aug 18 '22 17:08 OmerBenGera

It takes too long to process the recalc, therefore it fails. You can configure the timeout to be whatever you want it to be.

What's the bug I don't understand

Well before upgrading my build from 1.9.0-b615 to 1.11.1-b766 the recalc only took seconds and now it takes 9999999 seconds and they never receive the message saying it got updated.

LuluxClient avatar Aug 18 '22 17:08 LuluxClient

It takes too long to process the recalc, therefore it fails. You can configure the timeout to be whatever you want it to be. What's the bug I don't understand

Well before upgrading my build from 1.9.0-b615 to 1.11.1-b766 the recalc only took seconds and now it takes 9999999 seconds and they never receive the message saying it got updated.

It might be because of the lag you mentioned in your other issue. SSB sometimes need to load chunks and it does it slowly when the server is lagging to not make it worst.

OmerBenGera avatar Aug 18 '22 18:08 OmerBenGera

It takes too long to process the recalc, therefore it fails. You can configure the timeout to be whatever you want it to be. What's the bug I don't understand

Well before upgrading my build from 1.9.0-b615 to 1.11.1-b766 the recalc only took seconds and now it takes 9999999 seconds and they never receive the message saying it got updated.

It might be because of the lag you mentioned in your other issue. SSB sometimes need to load chunks and it does it slowly when the server is lagging to not make it worst.

Well why did change from a 3s task to a infinite task ? Even before my tps was as low as this and it never took more than 5s for the biggest and laggiest island

Also after doing /is admin recalc * I'm getting this huge error BUT the recalc works: https://pastebin.com/aYTck6Y4

I can send you the db in dms and you can try.

LuluxClient avatar Aug 18 '22 18:08 LuluxClient

It takes too long to process the recalc, therefore it fails. You can configure the timeout to be whatever you want it to be. What's the bug I don't understand

Well before upgrading my build from 1.9.0-b615 to 1.11.1-b766 the recalc only took seconds and now it takes 9999999 seconds and they never receive the message saying it got updated.

It might be because of the lag you mentioned in your other issue. SSB sometimes need to load chunks and it does it slowly when the server is lagging to not make it worst.

Well why did change from a 3s task to a infinite task ? Even before my tps was as low as this and it never took more than 5s for the biggest and laggiest island

Also after doing /is admin recalc * I'm getting this huge error BUT the recalc works: https://pastebin.com/aYTck6Y4

I can send you the db in dms and you can try.

Nothing was changed from 1.9.1 to recent versions. Also, don't do /is admin recalc *, it's cause the plugin to load a lot of chunks, which will make the tps go down even further. The error that you receive is not an error, it's a stacktrace after the server's thread stopped responding.

OmerBenGera avatar Aug 18 '22 19:08 OmerBenGera

It takes too long to process the recalc, therefore it fails. You can configure the timeout to be whatever you want it to be. What's the bug I don't understand

Well before upgrading my build from 1.9.0-b615 to 1.11.1-b766 the recalc only took seconds and now it takes 9999999 seconds and they never receive the message saying it got updated.

It might be because of the lag you mentioned in your other issue. SSB sometimes need to load chunks and it does it slowly when the server is lagging to not make it worst.

Well why did change from a 3s task to a infinite task ? Even before my tps was as low as this and it never took more than 5s for the biggest and laggiest island Also after doing /is admin recalc * I'm getting this huge error BUT the recalc works: https://pastebin.com/aYTck6Y4 I can send you the db in dms and you can try.

Nothing was changed from 1.9.1 to recent versions. Also, don't do /is admin recalc *, it's cause the plugin to load a lot of chunks, which will make the tps go down even further.

As you can see when changing the timeout to infinite players are stuck and can no longer place blocks: https://gyazo.com/1a0e95001f26cf300b7df6d6e3c0fccb

LuluxClient avatar Aug 18 '22 19:08 LuluxClient

It takes too long to process the recalc, therefore it fails. You can configure the timeout to be whatever you want it to be. What's the bug I don't understand

Well before upgrading my build from 1.9.0-b615 to 1.11.1-b766 the recalc only took seconds and now it takes 9999999 seconds and they never receive the message saying it got updated.

It might be because of the lag you mentioned in your other issue. SSB sometimes need to load chunks and it does it slowly when the server is lagging to not make it worst.

Well why did change from a 3s task to a infinite task ? Even before my tps was as low as this and it never took more than 5s for the biggest and laggiest island Also after doing /is admin recalc * I'm getting this huge error BUT the recalc works: https://pastebin.com/aYTck6Y4 I can send you the db in dms and you can try.

Nothing was changed from 1.9.1 to recent versions. Also, don't do /is admin recalc *, it's cause the plugin to load a lot of chunks, which will make the tps go down even further.

As you can see when changing the timeout to infinite players are stuck and can no longer place blocks: https://gyazo.com/1a0e95001f26cf300b7df6d6e3c0fccb

You should not set it to infinite.

OmerBenGera avatar Aug 19 '22 06:08 OmerBenGera

Ok but what could cause these issues ?

LuluxClient avatar Aug 19 '22 21:08 LuluxClient

Ok but what could cause these issues ?

As I said already, it's because it takes too long for chunks to load probably (that's my guess at least). Run /is admin debug Action: Chunk Load and then /is admin recalc <island> to the large island. Then, look in console and see if the chunks are loaded or not.

OmerBenGera avatar Aug 20 '22 06:08 OmerBenGera

Ok after doing that here is a gif and the console output: gif: https://gyazo.com/ce1684a61dae10f49f40cad92c407385 Console output: https://pastebin.com/dwnnCC9i

As you can see TPS is fine and at the end the recalc fails

LuluxClient avatar Aug 23 '22 12:08 LuluxClient

Ok after doing that here is a gif and the console output: gif: https://gyazo.com/ce1684a61dae10f49f40cad92c407385 Console output: https://pastebin.com/dwnnCC9i

As you can see TPS is fine and at the end the recalc fails

The plugin loads too many chunks because of entities recalculation, causing the entire chunks-loading queue to be filled with its chunks, clearly not an intended behavior. I will look into it.

OmerBenGera avatar Aug 25 '22 19:08 OmerBenGera

Ok after doing that here is a gif and the console output: gif: https://gyazo.com/ce1684a61dae10f49f40cad92c407385 Console output: https://pastebin.com/dwnnCC9i

As you can see TPS is fine and at the end the recalc fails

The plugin loads too many chunks because of entities recalculation, causing the entire chunks-loading queue to be filled with its chunks, clearly not an intended behavior.

I will look into it.

Perfect thanks <3

LuluxClient avatar Aug 25 '22 23:08 LuluxClient

Check out latest dev build, let me know if it's better.

OmerBenGera avatar Aug 27 '22 10:08 OmerBenGera

Check out latest dev build, let me know if it's better.

Hey I'll try thanks !

LuluxClient avatar Aug 27 '22 15:08 LuluxClient

Check out latest dev build, let me know if it's better.

Still not fixed and here is the debug output: https://pastebin.com/HsWiFiZD Tps: image

After 300s (set in the config) the recalc expires

LuluxClient avatar Aug 28 '22 11:08 LuluxClient

Also here is how big the island is: https://gyazo.com/0c48e61dd59687892dffbeec3081c2d3 (feel free to hide it so my players won't scream I leaked their island xd

and I think the issue might come from "old islands", if I copy paste their island and recalc it I have no issues, I had an old island which is super small and the recalc expired. here is my island on my test account (it's super small and has nothing except that: https://gyazo.com/b12d42715d0877cae3205202ee3e1c6d debug output: https://pastebin.com/FqbUPQrb

LuluxClient avatar Aug 28 '22 11:08 LuluxClient

Also tried on that island: image same issue

LuluxClient avatar Aug 28 '22 11:08 LuluxClient

There are no "Chunk Load Attempts" of BLOCKS_RECALCULATE?

OmerBenGera avatar Aug 28 '22 12:08 OmerBenGera

I dont seen any

Le dim. 28 août 2022 à 14:31, Ome_R @.***> a écrit :

There are no "Chunk Load Attempts" of BLOCKS_RECALCULATE?

— Reply to this email directly, view it on GitHub https://github.com/BG-Software-LLC/SuperiorSkyblock2/issues/1323#issuecomment-1229447490, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO5NOMFOC34E7FXXWOLICQDV3NL2FANCNFSM565POYFA . You are receiving this because you authored the thread.Message ID: @.***>

LuluxClient avatar Aug 28 '22 12:08 LuluxClient

I dont seen any Le dim. 28 août 2022 à 14:31, Ome_R @.> a écrit : There are no "Chunk Load Attempts" of BLOCKS_RECALCULATE? — Reply to this email directly, view it on GitHub <#1323 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO5NOMFOC34E7FXXWOLICQDV3NL2FANCNFSM565POYFA . You are receiving this because you authored the thread.Message ID: @.>

Just to make sure - For islands that works just fine it shows, but for bugged one it isnt?

OmerBenGera avatar Aug 28 '22 12:08 OmerBenGera

I’ll need to do some more testing since it’s really weird, if you wish you can log on the server and see for yourself since the issue is kinda hard to locate

Le dim. 28 août 2022 à 14:57, Ome_R @.***> a écrit :

I dont seen any Le dim. 28 août 2022 à 14:31, Ome_R @.

> a écrit : … <#m_3827561213299534681_> There are no "Chunk Load Attempts" of BLOCKS_RECALCULATE? — Reply to this email directly, view it on GitHub <#1323 (comment) https://github.com/BG-Software-LLC/SuperiorSkyblock2/issues/1323#issuecomment-1229447490>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO5NOMFOC34E7FXXWOLICQDV3NL2FANCNFSM565POYFA https://github.com/notifications/unsubscribe-auth/AO5NOMFOC34E7FXXWOLICQDV3NL2FANCNFSM565POYFA . You are receiving this because you authored the thread.Message ID: @.>

Just to make sure - For islands that works just fine it shows, but for bugged one it isnt?

— Reply to this email directly, view it on GitHub https://github.com/BG-Software-LLC/SuperiorSkyblock2/issues/1323#issuecomment-1229451897, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO5NOMEPFBU5OVKB5VWIAVLV3NO2NANCNFSM565POYFA . You are receiving this because you authored the thread.Message ID: @.***>

LuluxClient avatar Aug 28 '22 12:08 LuluxClient

I’ll need to do some more testing since it’s really weird, if you wish you can log on the server and see for yourself since the issue is kinda hard to locate Le dim. 28 août 2022 à 14:57, Ome_R @.> a écrit : I dont seen any Le dim. 28 août 2022 à 14:31, Ome_R @. > a écrit : … <#m_3827561213299534681_> There are no "Chunk Load Attempts" of BLOCKS_RECALCULATE? — Reply to this email directly, view it on GitHub <#1323 (comment) <#1323 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO5NOMFOC34E7FXXWOLICQDV3NL2FANCNFSM565POYFA https://github.com/notifications/unsubscribe-auth/AO5NOMFOC34E7FXXWOLICQDV3NL2FANCNFSM565POYFA . You are receiving this because you authored the thread.Message ID: @.> Just to make sure - For islands that works just fine it shows, but for bugged one it isnt? — Reply to this email directly, view it on GitHub <#1323 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO5NOMEPFBU5OVKB5VWIAVLV3NO2NANCNFSM565POYFA . You are receiving this because you authored the thread.Message ID: @.>

I'm also getting these errors on stop: https://pastebin.com/JxvR8fVZ (didn't happen before)

LuluxClient avatar Aug 29 '22 13:08 LuluxClient

I’ll need to do some more testing since it’s really weird, if you wish you can log on the server and see for yourself since the issue is kinda hard to locate Le dim. 28 août 2022 à 14:57, Ome_R @.> a écrit : I dont seen any Le dim. 28 août 2022 à 14:31, Ome_R @. > a écrit : … <#m_3827561213299534681_> There are no "Chunk Load Attempts" of BLOCKS_RECALCULATE? — Reply to this email directly, view it on GitHub <#1323 (comment) <#1323 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO5NOMFOC34E7FXXWOLICQDV3NL2FANCNFSM565POYFA https://github.com/notifications/unsubscribe-auth/AO5NOMFOC34E7FXXWOLICQDV3NL2FANCNFSM565POYFA . You are receiving this because you authored the thread.Message ID: @.> Just to make sure - For islands that works just fine it shows, but for bugged one it isnt? — Reply to this email directly, view it on GitHub <#1323 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO5NOMEPFBU5OVKB5VWIAVLV3NO2NANCNFSM565POYFA . You are receiving this because you authored the thread.Message ID: @.>

If you copy and paste your server files elsewhere and open with them a localhost, is it also still happening for these islands?

OmerBenGera avatar Sep 02 '22 08:09 OmerBenGera

Last time I tried i couldn’t reproduce it, I still have a backup I’ll try when I’m back from school (school just started today)

Le ven. 2 sept. 2022 à 10:16, Ome_R @.***> a écrit :

I’ll need to do some more testing since it’s really weird, if you wish you can log on the server and see for yourself since the issue is kinda hard to locate Le dim. 28 août 2022 à 14:57, Ome_R @.

> a écrit : … <#m_4490745956028366199_> I dont seen any Le dim. 28 août 2022 à 14:31, Ome_R @. > a écrit : … <#m_3827561213299534681_> There are no "Chunk Load Attempts" of BLOCKS_RECALCULATE? — Reply to this email directly, view it on GitHub <#1323 https://github.com/BG-Software-LLC/SuperiorSkyblock2/issues/1323 (comment) <#1323 (comment) https://github.com/BG-Software-LLC/SuperiorSkyblock2/issues/1323#issuecomment-1229447490>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO5NOMFOC34E7FXXWOLICQDV3NL2FANCNFSM565POYFA https://github.com/notifications/unsubscribe-auth/AO5NOMFOC34E7FXXWOLICQDV3NL2FANCNFSM565POYFA https://github.com/notifications/unsubscribe-auth/AO5NOMFOC34E7FXXWOLICQDV3NL2FANCNFSM565POYFA https://github.com/notifications/unsubscribe-auth/AO5NOMFOC34E7FXXWOLICQDV3NL2FANCNFSM565POYFA . You are receiving this because you authored the thread.Message ID: @.> Just to make sure - For islands that works just fine it shows, but for bugged one it isnt? — Reply to this email directly, view it on GitHub <#1323 (comment) https://github.com/BG-Software-LLC/SuperiorSkyblock2/issues/1323#issuecomment-1229451897>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO5NOMEPFBU5OVKB5VWIAVLV3NO2NANCNFSM565POYFA https://github.com/notifications/unsubscribe-auth/AO5NOMEPFBU5OVKB5VWIAVLV3NO2NANCNFSM565POYFA . You are receiving this because you authored the thread.Message ID: @.>

If you copy and paste your server files elsewhere and open with them a localhost, is it also still happening for these islands?

— Reply to this email directly, view it on GitHub https://github.com/BG-Software-LLC/SuperiorSkyblock2/issues/1323#issuecomment-1235207978, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO5NOMHZGYNVDITOROOF6P3V4GZXNANCNFSM565POYFA . You are receiving this because you authored the thread.Message ID: @.***>

LuluxClient avatar Sep 02 '22 08:09 LuluxClient

Last time I tried i couldn’t reproduce it, I still have a backup I’ll try when I’m back from school (school just started today) Le ven. 2 sept. 2022 à 10:16, Ome_R @.> a écrit : I’ll need to do some more testing since it’s really weird, if you wish you can log on the server and see for yourself since the issue is kinda hard to locate Le dim. 28 août 2022 à 14:57, Ome_R @. > a écrit : … <#m_4490745956028366199_> I dont seen any Le dim. 28 août 2022 à 14:31, Ome_R @. > a écrit : … <#m_3827561213299534681_> There are no "Chunk Load Attempts" of BLOCKS_RECALCULATE? — Reply to this email directly, view it on GitHub <#1323 <#1323> (comment) <#1323 (comment) <#1323 (comment)>>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO5NOMFOC34E7FXXWOLICQDV3NL2FANCNFSM565POYFA https://github.com/notifications/unsubscribe-auth/AO5NOMFOC34E7FXXWOLICQDV3NL2FANCNFSM565POYFA https://github.com/notifications/unsubscribe-auth/AO5NOMFOC34E7FXXWOLICQDV3NL2FANCNFSM565POYFA https://github.com/notifications/unsubscribe-auth/AO5NOMFOC34E7FXXWOLICQDV3NL2FANCNFSM565POYFA . You are receiving this because you authored the thread.Message ID: @.> Just to make sure - For islands that works just fine it shows, but for bugged one it isnt? — Reply to this email directly, view it on GitHub <#1323 (comment) <#1323 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO5NOMEPFBU5OVKB5VWIAVLV3NO2NANCNFSM565POYFA https://github.com/notifications/unsubscribe-auth/AO5NOMEPFBU5OVKB5VWIAVLV3NO2NANCNFSM565POYFA . You are receiving this because you authored the thread.Message ID: @.> If you copy and paste your server files elsewhere and open with them a localhost, is it also still happening for these islands? — Reply to this email directly, view it on GitHub <#1323 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO5NOMHZGYNVDITOROOF6P3V4GZXNANCNFSM565POYFA . You are receiving this because you authored the thread.Message ID: @.>

Tried on a dev server with the same map DB and everything and I'm not getting any issues, it might be related to the player count or multiple people doing /is recalc at the same time or more

LuluxClient avatar Sep 05 '22 12:09 LuluxClient

Also it works for some but sometimes it doesn't: https://gyazo.com/eb33e48f6e976575816eeee760e64585

It's super weird and I cannot identify the issue. Is it because the chunk is loaded / isn't or is it the player count ? or is it caused by the members being on the island ? I have no idea I tried lots of stuff and cannot figure it out. Do you mind adding a debug for the recalc for a precise island to see what's wrong / what it's trying to do ?

LuluxClient avatar Sep 05 '22 12:09 LuluxClient

Also it works for some but sometimes it doesn't: https://gyazo.com/eb33e48f6e976575816eeee760e64585

It's super weird and I cannot identify the issue. Is it because the chunk is loaded / isn't or is it the player count ? or is it caused by the members being on the island ? I have no idea I tried lots of stuff and cannot figure it out. Do you mind adding a debug for the recalc for a precise island to see what's wrong / what it's trying to do ?

I already sent you the debug command that can be used.

OmerBenGera avatar Sep 05 '22 12:09 OmerBenGera

I know but it doesn't have any useful informations.

LuluxClient avatar Sep 05 '22 12:09 LuluxClient

/is admin debug Action: Chunk Load

Here is the output that I already sent above: https://pastebin.com/riPUhwVB for a huge 300x300+ island

LuluxClient avatar Sep 05 '22 12:09 LuluxClient