MapEditor icon indicating copy to clipboard operation
MapEditor copied to clipboard

Published 20 hours ago • verified publisher icon BF3RM

[Bug] some bugs

Open FlashHit opened this issue 3 years ago • 2 comments

  • [x] Unknown GameObjectManager:GetEntityByGuid function https://github.com/BF3RM/MapEditor/blob/640b1f2d89f3b97426066094bcfb3196b9a98afa/ext/Shared/Modules/CommandActions.lua#L200
  • [x] v.value doesn't get passed https://github.com/BF3RM/MapEditor/blob/640b1f2d89f3b97426066094bcfb3196b9a98afa/ext/Shared/Modules/EBXManager.lua#L17
  • [x] unknown number function https://github.com/BF3RM/MapEditor/blob/640b1f2d89f3b97426066094bcfb3196b9a98afa/ext/Shared/Modules/EBXManager.lua#L40
  • [x] GameObjectManager.m_Entities unknown https://github.com/BF3RM/MapEditor/blob/640b1f2d89f3b97426066094bcfb3196b9a98afa/ext/Shared/Types/GameEntity.lua#L66
  • [ ] also GameEntity is a bad name for a lua class since we have a real GameEntity in vext, so rename it
  • [x] why is this commented out? and how is this not causing errors? this is used at so many places https://github.com/BF3RM/MapEditor/blob/640b1f2d89f3b97426066094bcfb3196b9a98afa/ext/Shared/Types/GameObject.lua#L20-L25
  • [ ] deprecated in lua 5.4 https://github.com/BF3RM/MapEditor/blob/640b1f2d89f3b97426066094bcfb3196b9a98afa/ext/Shared/Util/matrix.lua#L1042
  • [x] EditorCommon doesn't take any arguments https://github.com/BF3RM/MapEditor/blob/640b1f2d89f3b97426066094bcfb3196b9a98afa/ext/Server/init.lua#L14 https://github.com/BF3RM/MapEditor/blob/640b1f2d89f3b97426066094bcfb3196b9a98afa/ext/Client/init.lua#L15
  • [x] self.m_RequiredBundles is unknown https://github.com/BF3RM/MapEditor/blob/640b1f2d89f3b97426066094bcfb3196b9a98afa/ext/Server/ProjectManager.lua#L58 https://github.com/BF3RM/MapEditor/blob/640b1f2d89f3b97426066094bcfb3196b9a98afa/ext/Server/ProjectManager.lua#L216
  • [x] Editor.m_CurrentProjectHeader unknown https://github.com/BF3RM/MapEditor/blob/640b1f2d89f3b97426066094bcfb3196b9a98afa/ext/Client/init.lua#L134
  • [x] Editor:OnControlUpdate() doesn't take any arguments https://github.com/BF3RM/MapEditor/blob/640b1f2d89f3b97426066094bcfb3196b9a98afa/ext/Client/init.lua#L203

FlashHit avatar Jan 30 '22 02:01 FlashHit

why is this commented out? and how is this not causing errors? this is used at so many places

Ah it is done in the functions below

FlashHit avatar Jan 30 '22 06:01 FlashHit

also GameEntity is a bad name for a lua class since we have a real GameEntity in vext, so rename it

https://github.com/BF3RM/MapEditor/issues/331

FoolHen avatar Feb 15 '22 11:02 FoolHen