Edwin Cromley
Edwin Cromley
What does the audit entail? And would we also put it on the docs website? I would be glad to do whatever this issue is about. What type of consistency...
I can work on this but will need guidance. Basically it will be condensing error codes and improving error message?
Yeah, I started using ack after watching a wordpress.tv video of you haha. I don't know how to do the fancy output you do in your scripts though but will...
| File:Line | WP_Error | | --- | --- | | plugin.php:294 | ( 'rest_invalid_param', sprintf( __( '%s is not one of %s' ), $param, implode( ', ', $args['enum'] )...
If you want this formatted differently, let me know I will probably also check how many unique error_codes we have. From a quick glance overall, I think things look okay...
Some notes: A couple of mistakes on rest_invalid_date, rest_invalid_email, there are a bunch more throughout the API in users controller etc. Should any invalid query param should be rest_invalid_param? rest_forbidden_context...
@schlessera Yeah, I think that is a relatively good idea and it would improve consistency. It can be refactored to that system at any point. The naming and conventions is...
@schlessera Thank you for your thoughts. I like the way option 2 looks. I don't see too big of an advantage to go with option 1 vs. option 2. Option...
Should we also list the filters and what not on the v2.wp-api.org site?
Ya I will. What do we need to audit about the filters just to make sure we have a consistent structure and naming to them in the controllers?