react-zendesk icon indicating copy to clipboard operation
react-zendesk copied to clipboard

canUseDOM always "true"

Open dartess opened this issue 1 year ago • 2 comments

because it function, but used like boolean

dartess avatar Dec 21 '23 12:12 dartess

I'll have to defer to the owner of the repo.

In my view, it would probably be safer to simply call the function everywhere it is used instead of immediately invoking it at the top.

WilliamPriorielloGarda avatar Mar 14 '24 18:03 WilliamPriorielloGarda

I don't understand how this would be safer. sounds like unnecessary calls - the result of the call in real conditions will always be the same. In any case, my job is only to suggest changes.

dartess avatar Mar 23 '24 11:03 dartess