microsoft-authentication-library-for-dotnet icon indicating copy to clipboard operation
microsoft-authentication-library-for-dotnet copied to clipboard

Published 20 hours ago • verified publisher icon AzureAD

[Feature Request] Update logging guidance

Open trwalke opened this issue 3 years ago • 2 comments
trafficstars

Is your feature request related to a problem? Please describe. We recently added support for the IIdentityLogger and explained how one can use an environment variable in their code to change the log level without recompiling. This works for public clients, but confidential clients will have an issue since you need to restart the machine to get the updated env variables and these clients typically run in data centers and restarting the machine can be tricky or remove the reproduction of the issue all together.

Describe the solution you'd like Integrate Microsoft.Extensions.Logging and Microsoft.Extensions.Configuration into our documentation to show how developers may be able to use a configuration file to change the log level on while the service is still running.

Additional context https://www.nuget.org/packages/Microsoft.Extensions.Logging/7.0.0-preview.6.22324.4 https://www.nuget.org/packages/Microsoft.Extensions.Configuration/7.0.0-preview.6.22324.4

trwalke avatar Aug 04 '22 06:08 trwalke

Let's try to update the official docs as well after we update our wiki (or instead of). Happy to review the docs before getting published.

It should have 3 sections:

  1. General recommendations
  2. The Microsoft.Extensions.Logging logger
  3. The env variable logger

We will need to use the new Docs Editor for it - I found a demo of it here: https://microsoft.sharepoint.com/teams/CE_APEX/_layouts/15/stream.aspx?id=%2Fteams%2FCE%5FAPEX%2FDocuments%2FDevRel%20Online%20Team%2FPublishing%2Fdocs%2Deditor%2Dmvp%2Ddemo%2Emp4&ct=1659700103286&or=OWA-NT&cid=d1fd3378-da89-2df8-ba2d-959db7fc8245&ga=1

Also please work with Identity.Web to see if they need to update their implementation, which adapts from ILogger

bgavrilMS avatar Aug 05 '22 11:08 bgavrilMS

The MS Docs for logging is here: https://docs.microsoft.com/en-us/azure/active-directory/develop/msal-logging-dotnet?tabs=dotnet I also think the aka.ms/msal-net-logging needs to be changed to point to the MS docs and not our wiki.

pmaytak avatar Aug 05 '22 17:08 pmaytak

Link updated @pmaytak. Are we good to close this issue?

localden avatar Apr 17 '23 21:04 localden