[Internal] Automate API Review tool to protect against breaking API changes

[bgavrilMS]

trafficstars

ApiCompat is used for Wilson and SAL, and we should extend to MSAL.

Here is the task group that we are using for cloud builds. If you are using only NuGet packages to get contract assemblies, you can disregard parameters prefixed with “ado”.

[gladjohn]

@bgavrilMS checking to see if we still need this task?

[bgavrilMS]

Yeah, I think it would be nice to explore this tool again. Most likely we want to wait until we get rid of xamarin - these kind of tools don't work too well with ancient targets.

https://stackoverflow.com/questions/73257002/generate-text-file-of-public-api-of-net-library-for-versioning-and-compatibilit

[gladjohn]

Ok will revisit this after we remove xamarin support

[keegan-caruso]

Consider using this: https://learn.microsoft.com/en-us/dotnet/fundamentals/package-validation/baseline-version-validator

[bgavrilMS]

This is great, thanks for pointing this out @keegan-caruso. We should add this to MSAL, at least .net and .net fwk versions.

[bgavrilMS]

It should also help document the API diff between MSAL 4 and MSAL 5

[bgavrilMS]

Not worth it, we are not introducing that many apis.

[pmaytak]

Another possible analyzer tool: https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md