microsoft-authentication-library-for-android
microsoft-authentication-library-for-android copied to clipboard
PROD MSAL to DEV BROKER
Task: https://identitydivision.visualstudio.com/Engineering/_workitems/edit/1254660
Create pipeline with the following configuration Prod MSAL - Dev BROKER
Pipeline for review URL: https://identitydivision.visualstudio.com/Engineering/_build?definitionId=1791&_a=summary
Codecov Report
Merging #1716 (bceef57) into dev (3ac3354) will increase coverage by
0.66%. The diff coverage isn/a.
:exclamation: Current head bceef57 differs from pull request most recent head f0f37c4. Consider uploading reports for the commit f0f37c4 to get more accurate results
@@ Coverage Diff @@
## dev #1716 +/- ##
============================================
+ Coverage 48.89% 49.55% +0.66%
- Complexity 367 376 +9
============================================
Files 60 60
Lines 2712 2712
Branches 331 331
============================================
+ Hits 1326 1344 +18
+ Misses 1235 1224 -11
+ Partials 151 144 -7
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...y/client/PublicClientApplicationConfiguration.java | 28.44% <0.00%> (+0.88%) |
:arrow_up: |
| ...osoft/identity/client/PublicClientApplication.java | 44.14% <0.00%> (+0.96%) |
:arrow_up: |
| ...tity/client/internal/CommandParametersAdapter.java | 76.88% <0.00%> (+1.88%) |
:arrow_up: |
| ...nt/internal/controllers/MSALControllerFactory.java | 40.47% <0.00%> (+2.38%) |
:arrow_up: |
| .../com/microsoft/identity/client/AccountAdapter.java | 94.16% <0.00%> (+4.16%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
I think a lot of my comments on the other PR (https://github.com/AzureAD/android-complete/pull/162/) will also apply to this one. I don't want to spam this one as well :)
Probably get a review from @fadidurah as well
@wainaina , are you planning to merge this PR, or abort it?