microsoft-authentication-extensions-for-python icon indicating copy to clipboard operation
microsoft-authentication-extensions-for-python copied to clipboard

Published 20 hours ago • verified publisher icon AzureAD

Consider removing `portalocker` dependency

Open chlowell opened this issue 4 years ago • 1 comments

Primarily because it requires pywin32, which has been a troublesome (transitive) dependency. See for example these Azure SDK issues:

AssertionError upon importing pywin32 in Azure Function: Azure/azure-sdk-for-python#19989 Can't run python after installing pywin32 226: Azure/azure-sdk-for-python#8573 DLL load fails on Python 3.8: Azure/azure-sdk-for-python#8292

chlowell avatar Aug 20 '21 20:08 chlowell

Thanks for providing lots of materials here. We will take a look, and possibly re-open the previous research effort on relevant topics here and there.

Currently, the file locking is the reason we use portalocker, because we do not want to get ourselves into the file locking business. We will need some investigation to see what we can do here.

rayluo avatar Aug 20 '21 21:08 rayluo