azure-service-operator
azure-service-operator copied to clipboard
Azure
Feature Enhancement: Enable Backup Instance creation for Microsoft.DataProtection
What this PR does / why we need it:
This pull request introduces enhancement for Backup Instance creation for Microsoft.DataProtection. Additionally, we have added the necessary test recording that covers the creation, and deletion of these resources, namely Backup Instance with thorough validation.
Special notes for your reviewer: Feature enhancement on top of already existing Microsoft.DataProtection CRDs.
How does this PR make you feel:
If applicable:
- [x] this PR contains documentation
- [x] this PR contains tests
- [x] this PR contains YAML Samples
You'll need to fix the sample, and include the recording of the test run.
Test recordings are included: https://github.com/mayankagg9722/azure-service-operator/blob/main/v2/internal/controllers/recordings/Test_Dataprotection_Backupinstace_CRUD.yaml
We need to increase the CI timeout for our test case as BI sync will take time. Otherwise its running fine and test recording is also included.
We need to increase the CI timeout for our test case as BI sync will take time. Otherwise its running fine and test recording is also included.
Why? CI builds run an accelerated replay of the recordings and don't interact with Azure at all.
of the recordings and don't interact with Azure at all.
Okay, sure. I will check once again if I am able to find anything useful from CI logs about this step failing.
This is getting close to complete; once you've addressed the last couple of comments and rerecorded the test (after merging main, as discussed offline), we should be able to merge.
I have addressed all the comments. Merged with upstream main and regenerated and added test recordings.
![azure-pipelines[bot] avatar](https://avatars.githubusercontent.com/in/9426?v=4 "Published by a pub.dev verified publisher"){kind=small}
